Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Make linter tolerate org/repo references #6011

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jan 21, 2025

@jsoref jsoref requested a review from a team as a code owner January 21, 2025 18:13
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see those failures first, though over one of your smaller PRs. Thanks for submitting those! 🙌🏻

@jsoref
Copy link
Contributor Author

jsoref commented Jan 22, 2025

@chalin
Copy link
Contributor

chalin commented Jan 23, 2025

Thanks. If you see the issue pop up for one of your smaller PRs, let us know.

@jsoref
Copy link
Contributor Author

jsoref commented Jan 23, 2025

It'd be for a link commit: 614044d. People haven't suggested how they want to ingest those, so, they're currently waiting for a recommendation.

@chalin chalin force-pushed the ci-linter-org-links branch from a3ea443 to bf1ffe5 Compare January 23, 2025 04:09
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsoref
Copy link
Contributor Author

jsoref commented Jan 23, 2025

@tiffany76 tiffany76 added this pull request to the merge queue Jan 23, 2025
Merged via the queue into open-telemetry:main with commit 7c9dfa1 Jan 23, 2025
17 checks passed
@jsoref jsoref deleted the ci-linter-org-links branch January 23, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants