Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Spelling: dashboard...id #6018

Merged
merged 6 commits into from
Jan 23, 2025
Merged

[chore] Spelling: dashboard...id #6018

merged 6 commits into from
Jan 23, 2025

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jan 22, 2025

@jsoref jsoref requested a review from a team as a code owner January 22, 2025 02:48
@opentelemetrybot opentelemetrybot requested review from a team January 22, 2025 02:48
@jsoref jsoref changed the title Spelling 3 [chore] Spelling: dashboard...id Jan 22, 2025
chalin
chalin reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM once your rebased from main@HEAD and resolved conflicts. Thanks

@chalin chalin self-assigned this Jan 22, 2025
@opentelemetrybot opentelemetrybot requested review from a team January 23, 2025 02:32
jsoref added 6 commits January 22, 2025 22:25
@jsoref
spelling: dashboard
32dca8d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: endpoint
a524180 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: grafana
37c13a8 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: html
3758c59 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: htmltest
50e5e2c 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: id
f57b7f2 
Signed-off-by: Josh Soref <[email protected]>
chalin
chalin approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@chalin chalin added this pull request to the merge queue Jan 23, 2025
Merged via the queue into open-telemetry:main with commit 1f6a173 Jan 23, 2025
17 checks passed
@jsoref jsoref deleted the spelling-3 branch January 23, 2025 12:07
@jsoref jsoref mentioned this pull request Jan 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

@reyang reyang reyang approved these changes

@steverao steverao steverao approved these changes

Assignees

@chalin chalin

Labels
blog sig:demo sig:java sig:javascript
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsoref @chalin @reyang @steverao