-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update protocol defined for internal collection #6279
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Awaiting final approval of @open-telemetry/collector-approvers.
Thanks for staying on top of the changes, @mjuarez! I see that the changelog update isn't quite merged yet, so let's ask the @open-telemetry/collector-approvers to take a look. One additional question. Do we need to add a comment about versions? Something like, "if you're using Collector v0.118.0 or older, |
I know the changelog update isn't in, but had a peer on my team reference the existing doc while using the latest published version (0.119.0) and it was broken for them. So anyone new to otel-collector wouldn't be set up for success. I'm unsure about distinguishing config options by version. Has that been used elsewhere in the docs I can use as an example? Happy to update. |
I think we can skip the versioning comment, since as you point out @mjuarez, this is a configuration change. With apologies for delaying this PR a bit longer.... As I was looking through the internal telemetry page, I saw that |
Ah, good catch, yes! This needs to be removed as well |
Per open-telemetry/opentelemetry-collector#12332, a breaking change for the protocol used was introduced