fx: update Docker Go base images#239
Merged
Merged
Conversation
jim-junior
approved these changes
May 31, 2026
jim-junior
left a comment
jim-junior
left a comment
Member
There was a problem hiding this comment.
LGTM,
Ran it in a Codespace and it builds successfully
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates both Docker build stages from
golang:1.24.0togolang:1.25.0, matching thego 1.25.0directive ingo.mod. This keeps the Ubuntu and Alpine image builds on a base image that satisfies the module's declared Go version.Closes #237
Verification
git diff --check -- packaging/docker/Dockerfile.ubuntu packaging/docker/Dockerfile.alpinegolang:tags match thego.modGo versionI also attempted
APP_ENV=test go test ./...; dependencies resolved, but the suite hit an existing embedded-etcd integration failure (failed to create WAL). A local Docker build reached the Go build stage with the updated base image but was cut short by the local command timeout while downloading/building dependencies.