Use lattice package to run all the schema-205 jobs#65
Open
tanaya-mankad wants to merge 18 commits intomainfrom
Open
Use lattice package to run all the schema-205 jobs#65tanaya-mankad wants to merge 18 commits intomainfrom
tanaya-mankad wants to merge 18 commits intomainfrom
Conversation
nealkruis
requested changes
Dec 23, 2025
Contributor
nealkruis
left a comment
nealkruis
left a comment
There was a problem hiding this comment.
There are still a lot of files in the schema205 directory. I want to make sure that all of these files are still necessary, and if they are we should have a plan for how we will move the content either into lattice or elsewhere in this repository or the standard-205 repository.
Contributor
There was a problem hiding this comment.
We don't want the docs folder here (since the documentation is defined in the private standard-205 repository).
Comment on lines
+66
to
+68
| Required Data Elements: | ||
| rating_reproducible_from_data: | ||
| Type: Boolean |
Contributor
There was a problem hiding this comment.
This somehow crept in (likely from an early version of the lattice examples). It needs to be removed from here and all the rating data groups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the features that were disparately implemented by scripts in schema205 are now subsumed in lattice, and the tool can be called from a high level.