Skip to content

Address addendum e comments #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elyse-malherek wants to merge 6 commits into
base: draft-rs-ashp
Choose a base branch
from
+23 −24
Open

Address addendum e comments #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d62231f
Remove AHRI references.
elyse-malherek Jul 21, 2025
7afeac7
Update constraints to include zero.
elyse-malherek Jul 21, 2025
aa480d1
Revert "Update constraints to include zero."
elyse-malherek Jul 21, 2025
a4b7f46
Update constraints to include 0
elyse-malherek Jul 21, 2025
bf2585c
Update "sump" to "crankcase"
elyse-malherek Jul 21, 2025
dade30f
Remove dehumidification and humidification from performance capabilities
elyse-malherek Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions schema-source/ASHRAE205.schema.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,13 @@ PerformanceCapabilities:
HEATING:
Description: "Indicates that the equipment provides explicitly controlled heating and the representation contains heating-related performance data"
Display Text: "Heating"
DEHUMIDIFICATION:
Description: "Indicates that the equipment provides explicitly controlled dehumidification and the representation contains dehumidification-related performance data"
Display Text: "Dehumidification"
HUMIDIFICATION:
Description: "Indicates that the equipment provides explicitly controlled humidification and the representation contains humidification-related performance data"
Display Text: "Humidification"
# TODO: Reserved for future use
# DEHUMIDIFICATION:
# Description: "Indicates that the equipment provides explicitly controlled dehumidification and the representation contains dehumidification-related performance data"
# Display Text: "Dehumidification"
# HUMIDIFICATION:
# Description: "Indicates that the equipment provides explicitly controlled humidification and the representation contains humidification-related performance data"
# Display Text: "Humidification"


#Common Data Groups
Expand Down
34 changes: 16 additions & 18 deletions schema-source/RS0004.schema.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,21 +70,19 @@ Performance:
Data Type: "<SpeedControlType>"
Required: True
cooling_cycling_degradation_coefficient:
Description: "Cooling cycling degradation coefficient (C~D~^c^) as described in AHRI 210/240"
Description: "Cooling cycling degradation coefficient (C~D~^c^)"
Data Type: "Numeric"
Units: "-"
Constraints: [">=0.0","<1.0"]
Required: "if performance_capabilities contains(COOLING)"
Notes: ["Used for the lowest stage when the unit cycles to meet load",
"***Informative note:*** 340/360 specifies a fixed cycling degradation coefficient of approximately 0.12"]
Notes: ["Used for the lowest stage when the unit cycles to meet load"]
heating_cycling_degradation_coefficient:
Description: "Heating cycling degradation coefficient (C~D~^h^) as described in AHRI 210/240"
Description: "Heating cycling degradation coefficient (C~D~^h^)"
Data Type: "Numeric"
Units: "-"
Constraints: [">=0.0","<1.0"]
Required: "if performance_capabilities contains(HEATING)"
Notes: ["Used for the lowest stage when the unit cycles to meet load",
"***Informative note:*** 340/360 specifies a fixed cycling degradation coefficient of approximately 0.12"]
Notes: ["Used for the lowest stage when the unit cycles to meet load"]
scaling:
Description: "Specifies the range the performance data can be scaled to represent different capacity equipment"
Data Type: "{Scaling}"
Expand Down Expand Up @@ -140,7 +138,7 @@ GridVariablesCooling:
indoor_coil_air_mass_flow_rate:
Description: "Mass flow rate of air entering the indoor coil"
Data Type: "[Numeric][1..]"
Constraints: ">0.0"
Constraints: ">=0.0"
Units: "kg/s"
Required: True
Scalable: True
Expand Down Expand Up @@ -181,11 +179,11 @@ LookupVariablesCooling:
gross_power:
Description: "Gross power draw (of the outdoor unit)"
Data Type: "[Numeric][1..]"
Constraints: ">0.0"
Constraints: ">=0.0"
Units: "W"
Required: True
Scalable: True
Notes: ["Includes compressor, outdoor fan, and any auxiliary power used by the unit's controls and any sump heater",
Notes: ["Includes compressor, outdoor fan, and any auxiliary power used by the unit's controls and any crankcase heater",
"Shall not include power drawn by the indoor fan"]
operation_state:
Description: "The operation state at the operating conditions"
Expand Down Expand Up @@ -230,7 +228,7 @@ GridVariablesHeating:
indoor_coil_air_mass_flow_rate:
Description: "Mass flow rate of air entering the indoor coil"
Data Type: "[Numeric][1..]"
Constraints: ">0"
Constraints: ">=0"
Units: "kg/s"
Required: True
Scalable: True
Expand All @@ -248,7 +246,7 @@ LookupVariablesHeating:
gross_steady_state_capacity:
Description: "Total heat added by the indoor coil under steady-state conditions (i.e., does not include the impact of frost accumulation or defrost operation)"
Data Type: "[Numeric][1..]"
Constraints: ">0"
Constraints: ">=0"
Units: "W"
Required: True
Scalable: True
Expand All @@ -258,7 +256,7 @@ LookupVariablesHeating:
gross_integrated_capacity:
Description: "Total heat added by the indoor coil integrated over the time between defrost terminations"
Data Type: "[Numeric][1..]"
Constraints: ">0"
Constraints: ">=0"
Units: "W"
Required: True
Scalable: True
Expand All @@ -268,25 +266,25 @@ LookupVariablesHeating:
gross_steady_state_power:
Description: "Gross power draw of the outdoor unit under steady-state conditions (i.e., does not include the impact of frost accumulation or defrost operation)"
Data Type: "[Numeric][1..]"
Constraints: ">0"
Constraints: ">=0"
Units: "W"
Required: True
Scalable: True
Notes:
- "Sometimes also referred to as \"instantaneous\" power"
- "Does not include power drawn by the indoor fan"
- "Includes compressor, outdoor fan, and any auxiliary power used by the unit's controls and any sump heater"
- "Includes compressor, outdoor fan, and any auxiliary power used by the unit's controls and any crankcase heater"
gross_integrated_power:
Description: "Gross power draw of the outdoor unit integrated over the time between defrost terminations"
Data Type: "[Numeric][1..]"
Constraints: ">0"
Constraints: ">=0"
Units: "W"
Required: True
Scalable: True
Notes:
- "Sometimes referred to as \"frost accumulation\" power"
- "Does not include power drawn by the indoor fan"
- "Includes compressor, outdoor fan, and any auxiliary power used by the unit's defrost process, controls, and any sump heater"
- "Includes compressor, outdoor fan, and any auxiliary power used by the unit's defrost process, controls, and any crankcase heater"
defrost_cycle_frequency:
Description: "Frequency of defrost terminations under the current operating conditions"
Data Type: "[Numeric][1..]"
Expand Down Expand Up @@ -328,8 +326,8 @@ LookupVariablesStandby:
gross_power:
Description: "Gross power draw (of the outdoor unit)"
Data Type: "[Numeric][1..]"
Constraints: ">0.0"
Constraints: ">=0.0"
Units: "W"
Required: True
Scalable: True
Notes: "Includes any auxiliary power used by the unit's controls and any sump heater"
Notes: "Includes any auxiliary power used by the unit's controls and any crankcase heater"