test: Add system tests for exercise administration #3008
Conversation
arkirchner
force-pushed
the
ak/system_test_exercise_form
branch
2 times, most recently
from
e2d0d2a to
1deabb1
Compare
| end | ||
| end | ||
|
|
||
| def chosen_select(name, value) |
There was a problem hiding this comment.
For now I want to keep the helper methods directly in the test. If further system tests need them, I would consider extracting them.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3008 +/- ##
==========================================
+ Coverage 70.05% 70.20% +0.15%
==========================================
Files 215 215
Lines 6846 6901 +55
==========================================
+ Hits 4796 4845 +49
- Misses 2050 2056 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The exercise administration form is a critical pass. The test will secure the functionality with the upcoming changes. Relates to #2922
arkirchner
force-pushed
the
ak/system_test_exercise_form
branch
from
1deabb1 to
5b124c0
Compare
| within('.markdown-editor__wrapper') do | ||
| find('.ProseMirror').set(description) | ||
| end |
There was a problem hiding this comment.
I wonder if these very specific class selectors might cause brittleness in the future if a refactoring is upcoming
There was a problem hiding this comment.
I looked at this again. I hoped to find something like role="textbox" and/or aria-label="Description". But I cannot find anything that would be considered expected. I have no practical solution here.
I don't want to make any any UI change in this PR. Eventually I want to make the form accessible to screen readers. That would resolve the issues with testing.
For now I want to use this brittle implementation until we can make this page accessible. 🤔
spec/system/exercises_system_spec.rb
Outdated
|
|
||
| click_button I18n.t('shared.create', model: Exercise.model_name.human) | ||
|
|
||
| expect(page).to have_text 'Exercise has successfully been created.' |
There was a problem hiding this comment.
This could also use a translation
There was a problem hiding this comment.
Sorry I overlooked this. Fixed!
spec/system/exercises_system_spec.rb
Outdated
| let!(:exercise) { create(:fibonacci) } | ||
| let(:teacher) { exercise.user } |
There was a problem hiding this comment.
| let!(:exercise) { create(:fibonacci) } | |
| let(:teacher) { exercise.user } | |
| let!(:exercise) { create(:fibonacci, user: teacher) } |
There was a problem hiding this comment.
I would move the teacher declaration to the outer scope (and assign the user in the exercise directly)
There was a problem hiding this comment.
Right. Thank you! Fixed.
The exercise administration form is a critical pass. The test will secure the functionality with the upcoming changes.
Relates to #2922