[WIP] BP5 Put performance optimization #1756
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I checked it. Works!! |
franzpoeschel
force-pushed
the
bp5-performance-optimization
branch
from
04982dd to
17c8621
Compare
franzpoeschel
commented
Jul 7, 2025
| engine.Put(var, ptr); | ||
| auto do_defer = | ||
| ba.m_is_bp5 ? adios2::Mode::Sync : adios2::Mode::Deferred; | ||
| engine.Put(var, ptr, do_defer); |
There was a problem hiding this comment.
This incurs an overhead in EndStep() / PerformDataWrite(). Use Async in those cases.
|
@pnorbert @eisenhauer can you take a look at this? @franzpoeschel and I wonder if this is a performance bug that rather should be fixed in ADIOS2. |
franzpoeschel
changed the title
ax3l
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #1751, BP5 performance takes a hit by calling PerformPuts(). Instead, for BP5, always use Put(Sync), so that we can skip PerformPuts().
@guj Can you check if this really improves performance?