Open
Conversation
openruyi-bot
bot
added
Community: Contribution
misaka00251
removed
the
Community: Contribution
Member
|
Please add the reason in the Pull Request description about why these packages should be included. |
Contributor
Author
|
sbsigntools is a signing utility for UEFI secure boot. sbsigntools requires gnu-efi. |
Z572
requested changes
Apr 13, 2026
openruyi-bot
bot
added
the
BuildSystem: autotools
Z572
requested changes
Apr 13, 2026
misaka00251
reviewed
Apr 13, 2026
SPECS/gnu-efi/gnu-efi.spec
Outdated
| BuildRequires: gcc | ||
|
|
||
| %description | ||
| Building EFI Applications Using the GNU Toolchain |
Member
There was a problem hiding this comment.
Why is there a blank space here?
misaka00251
reviewed
Apr 13, 2026
| BuildOption(prep): -n%{name}-%{version} | ||
| BuildOption(build): LD=ld.bfd PREFIX=%{_prefix} LIBDIR=%{_libdir} INSTALLROOT=%{buildroot} | ||
| BuildOption(install): LD=ld.bfd PREFIX=%{_prefix} LIBDIR=%{_libdir} INSTALLROOT=%{buildroot} | ||
| BuildRequires: make |
Member
There was a problem hiding this comment.
Please insert an extra newline here. The BuildRequires section should be formatted as its own distinct block.
misaka00251
reviewed
Apr 13, 2026
SPECS/gnu-efi/gnu-efi.spec
Outdated
Comment on lines
+15
to
+16
|
|
||
| BuildSystem: autotools |
Member
There was a problem hiding this comment.
Source0: https://github.com/ncroxon/gnu-efi/archive/refs/tags/%{version}.tar.gz
BuildSystem: autotools
BuildSystem section should be formatted below Source (or BuildArch). But it should not be separated.
misaka00251
reviewed
Apr 13, 2026
| Version: 4.0.4 | ||
| Release: %autorelease | ||
| Summary: Building EFI Applications Using the GNU Toolchain | ||
| License: GPL-2.0-or-later/BSD-3-Clause |
Contributor
Author
There was a problem hiding this comment.
Different parts have different licenses.
Member
There was a problem hiding this comment.
It should be AND or OR or WITH anyway: https://openruyi.cn/governance/legal/spdx
misaka00251
requested changes
Apr 13, 2026
sbsigntools is a signing utility for UEFI secure boot. sbsigntools requires gnu-efi. Signed-off-by: Xiang W <wangxiang@iscas.ac.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.