Remove requirement for DNS to exist before machine is created #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchoolGuy
force-pushed
the
feature/remove-dns-check
branch
from
d46af16 to
ed164f0
Compare
marv7000
force-pushed
the
feature/remove-dns-check
branch
from
ed164f0 to
c54832a
Compare
SchoolGuy
force-pushed
the
feature/remove-dns-check
branch
from
15e4022 to
1451ba7
Compare
Cobbler generated the DNS entries that match the machine. As such there is no need that the DNS entry is existing before the machine itself is entered into Cobbler. Co-authored-by: Marvin Friedrich <[email protected]>
SchoolGuy
force-pushed
the
feature/remove-dns-check
branch
from
1451ba7 to
fe4f275
Compare
|
The remaining TODO for this PR is to refactor |
marv7000
force-pushed
the
feature/remove-dns-check
branch
from
d47adc8 to
f499698
Compare
marv7000
force-pushed
the
feature/remove-dns-check
branch
from
f499698 to
3714504
Compare
marv7000
approved these changes
Apr 8, 2025
This was referenced Apr 9, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #253
This PR removes the need for Orthos 2 to have machines added to the DNS before entering their data. This will use Cobbler under the hood to generate the zonefile that is needed so the machines are resolvable via DNS.