docs(markdown) Adding arguments of agents.gemini.discord.enabled=true and specify Gemini model.#595
Open
wesley990 wants to merge 3 commits intoopenabdev:mainfrom
Open
docs(markdown) Adding arguments of agents.gemini.discord.enabled=true and specify Gemini model.#595wesley990 wants to merge 3 commits intoopenabdev:mainfrom
wesley990 wants to merge 3 commits intoopenabdev:mainfrom
Conversation
Adding arguments of agents.gemini.discord.enabled=true and specify Gemini model.
github-actions
Bot
added
closing-soon
Adding arguments of agents.gemini.discord.enabled=true and specify Gemini model (optional).
github-actions
Bot
removed
the
closing-soon
wesley990
changed the title
wesley990
changed the title
CHC-Agent
reviewed
Apr 30, 2026
CHC-Agent
left a comment
CHC-Agent
left a comment
There was a problem hiding this comment.
Review Summary
Verdict: 🟡 Minor issues → ✅ Fixed
What this PR does
Fixes two gaps in docs/gemini.md Helm install instructions:
- Adds missing
--set agents.gemini.discord.enabled=true— without this, the[discord]config block is never generated and the bot token is never injected, so Gemini silently fails to connect to Discord. - Documents how to specify a Gemini model via
args(optional).
What was fixed in follow-up commit
- Typo:
defalut→default - Formatting: extra leading space before
(Optional), missing space before backtick
Verdict
Good to merge. The enabled=true fix addresses a real documentation bug that would block new users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding arguments of agents.gemini.discord.enabled=true and specify Gemini model.
Per https://discord.com/channels/1491295327620169908/1491365158868619404/1498273257214840862