Skip to content

fix(chart): use hasKey for boolean enabled to avoid Go template default trap #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thepagent merged 2 commits into from
May 1, 2026
+5 −5
Merged

fix(chart): use hasKey for boolean enabled to avoid Go template default trap #639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c345d41
fix(chart): use hasKey for boolean enabled fields to avoid Go templat…
Apr 30, 2026
1f391a5
fix(chart): apply hasKey to removeAfterReply and usercronEnabled
May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions charts/openab/templates/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ data:
session_ttl_hours = {{ ($cfg.pool).sessionTtlHours | default 24 }}

[reactions]
enabled = {{ ($cfg.reactions).enabled | default true }}
remove_after_reply = {{ ($cfg.reactions).removeAfterReply | default false }}
enabled = {{ if hasKey ($cfg.reactions) "enabled" }}{{ ($cfg.reactions).enabled }}{{ else }}true{{ end }}
remove_after_reply = {{ if hasKey ($cfg.reactions) "removeAfterReply" }}{{ ($cfg.reactions).removeAfterReply }}{{ else }}false{{ end }}
{{- if ($cfg.reactions).toolDisplay }}
{{- if not (has ($cfg.reactions).toolDisplay (list "full" "compact" "none")) }}
{{- fail (printf "agents.%s.reactions.toolDisplay must be one of: full, compact, none — got: %s" $name ($cfg.reactions).toolDisplay) }}
Expand Down Expand Up @@ -163,14 +163,14 @@ data:
{{- if or ($cfg.cronjobs) (($cfg.cron).usercronEnabled) (($cfg.cron).usercronPath) }}

[cron]
usercron_enabled = {{ (($cfg.cron).usercronEnabled) | default false }}
usercron_enabled = {{ if hasKey ($cfg.cron) "usercronEnabled" }}{{ (($cfg.cron).usercronEnabled) }}{{ else }}false{{ end }}
{{- if (($cfg.cron).usercronPath) }}
usercron_path = {{ ($cfg.cron).usercronPath | toJson }}
{{- end }}
{{- range ($cfg.cronjobs) }}

[[cron.jobs]]
enabled = {{ .enabled | default true }}
enabled = {{ if hasKey . "enabled" }}{{ .enabled }}{{ else }}true{{ end }}
schedule = {{ .schedule | toJson }}
channel = {{ .channel | toJson }}
message = {{ .message | toJson }}
Expand Down
2 changes: 1 addition & 1 deletion charts/openab/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ agents:
# - schedule: "0 9 * * 1-5"
# channel: "123456789"
# message: "summarize yesterday's merged PRs"
# enabled: true # set to false to disable this job without removing it
# enabled: true # false = skip scheduling (job config is still validated at startup)
# platform: "discord"
# senderName: "DailyOps"
# timezone: "Asia/Taipei"
Expand Down
Loading