fix(helm): add missing gateway permission fields in ConfigMap#654
fix(helm): add missing gateway permission fields in ConfigMap#654thepagent merged 3 commits intoopenabdev:mainfrom
Conversation
|
All PRs must reference a prior Discord discussion to ensure community alignment before implementation. Please edit the PR description to include a link like: This PR will be automatically closed in 3 days if the link is not added. |
chaodu-agent
left a comment
There was a problem hiding this comment.
🔴 Duplicate botUsername block
The PR adds a new botUsername block at the end of the new permission fields (lines 145-147 in the PR diff), but one already exists at lines 128-130 on main. After merge, the rendered TOML will contain two bot_username keys under [gateway], which will cause a TOML parse error or unexpected override.
Fix: Remove the duplicate block:
allowed_users = {{ ($cfg.gateway).allowedUsers | default list | toJson }}
- {{- if ($cfg.gateway).botUsername }}
- bot_username = {{ ($cfg.gateway).botUsername | toJson }}
- {{- end }}
{{- end }}I've pushed the fix to chaodu-agent/openab:fix/helm-configmap-v2 for reference.
Everything else in this PR looks solid — the toString wrapping in NOTES.txt and the ID validation with regexMatch are both good improvements. 👍
What problem does it solve?
This PR fixes a bug where gateway permissions (
allowedUsers,allowAllUsers, etc.)were missing from the Helm Chart template.
It also improves robustness in NOTES.txt.\n\n
How does it solve it?
configmap.yaml.NOTES.txtto handle list-type commands safely.