fix(reactions): restore tool_display default to full#659
Merged
Conversation
PR #658 changed the default from full to compact, which is a breaking change for existing deployments — users who never set tool_display would silently get different behavior after upgrading. Restore the original default (full) so upgrades are non-breaking. Users who want compact can opt in explicitly. Ref: #658
github-actions
Bot
added
pending-screening
…ault Addresses review feedback from 擺渡法師 — these two docs still referenced compact as the default after the config.rs change. - docs/config-reference.md: update default column to "full" - docs/tool-display.md: reorder modes (full first), fix examples, replace "Default changed" note with accurate description
Ensures ToolDisplay::default() == Full so any future change to the default will break CI and require explicit acknowledgment. Suggested-by: 擺渡法師
thepagent
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore
tool_displaydefault fromcompactback tofullto fix a breaking change introduced in #658.Discord Discussion URL: https://discord.com/channels/1486155598964719616/1499505047845736458
Problem
PR #658 changed the default
tool_displayfromfull(original behavior) tocompact. This is a breaking change — existing deployments that never explicitly settool_displaywould silently get different behavior after upgrading.Fix
#[default]fromCompacttoFullin theToolDisplayenum (src/config.rs)values.yamlcomments to reflectfullas the defaultUsers who want
compactmode can opt in explicitly:Changes
src/config.rs: Move#[default]attribute toFullvariant, update doc commentscharts/openab/values.yaml: Update 4 comment lines to showfullas defaultRef: #658