Rescale observation wrapper #1940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, you should check that unit tests are running. Try |
hartikainen
force-pushed
the
rescale-observation-wrapper
branch
from
5b520d5 to
e234862
Compare
pzhokhov
reviewed
Jun 19, 2020
|
|
||
| For `Box` spaces, `low` and `high` can be either scalar or vector, and | ||
| will be broadcasted according to numpy broadcasting rules. For `Tuple` | ||
| and `Dict` spaces, both `low` and `high` are expected to be scalar. |
There was a problem hiding this comment.
could you specify in the docstring that elements of Tuple or Dict space are expected to be Box?
|
Thanks for the PR @hartikainen! Looks good, but I would add
|
|
I'm closing this per #2259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1939