Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#94): handle special parameters (self/cls) correctly with context parameter #137

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shehryar718
Copy link

Fixes #94

Description

  • Fix issue where special parameters (self/cls) were being incorrectly filtered
  • Add tests to verify context parameter works correctly with special parameters
  • Ensure schema only contains actual function parameters, not special ones

Testing

  • Added comprehensive test cases:
    • Instance methods with context
    • Class methods with context
    • Static methods with context
  • Verified special parameters (self/cls) are properly handled
  • Confirmed schema generation excludes special parameters

Related Issue

This PR addresses issue #94

Checklist

  • Tests added/updated and passing locally
  • Code follows project style guidelines
  • Documentation updated (if required)
  • Issue linked in the PR description

…meter

- Fix issue where special parameters (self/cls) were being incorrectly filtered
- Add tests to verify context parameter works correctly with special parameters
- Ensure schema only contains actual function parameters, not special ones
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add method_tool Functionality
1 participant