Add local page handling to LocalPlaywrightComputer #11
+26
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add event listeners for page creation in local browser - Implement page handling similar to BrowserbaseBrowser - Fix issue with new tabs not being detected
|
This helped me. Otherwise, it would just open new tabs in MS Copilot's for some reason. Though, for some reason,n it searched for |
2 tasks
|
Thank you! Merging this now. |
katia-openai
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current LocalPlaywrightComputer implementation does not properly handle new browser tabs events.
Solution
Added page handling functionality to LocalPlaywrightComputer similar to BrowserbaseBrowser:
When a new tab is created, the terminal now shows "New page created" message and properly switches to it.