Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BasePlaywrightComputer): change page on new page event #9

Closed
wants to merge 1 commit into from
+8 −0
Closed

fix(BasePlaywrightComputer): change page on new page event #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions computers/base_playwright.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ def __enter__(self):
self._playwright = sync_playwright().start()
self._browser, self._page = self._get_browser_and_page()

self._listen_for_new_page(self._browser)

# Set up network interception to flag URLs matching domains in BLOCKED_DOMAINS
def handle_route(route, request):

Expand Down Expand Up @@ -146,6 +148,12 @@ def back(self) -> None:
def forward(self) -> None:
self._page.go_forward()

def _listen_for_new_page(self, browser: Browser) -> None:
def handle_new_page(page: Page):
self._page = page

browser.contexts[-1].on("page", handle_new_page)

# --- Subclass hook ---
def _get_browser_and_page(self) -> tuple[Browser, Page]:
"""Subclasses must implement, returning (Browser, Page)."""
Expand Down