Fix generation of StreamingResponseTextAnnotationAddedUpdate
#507
+251
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaspardpetit
reviewed
Jul 3, 2025
| @@ -5499,7 +5499,20 @@ public class StreamingResponseRefusalDoneUpdate : StreamingResponseUpdate, IJson | |||
| protected override BinaryData PersistableModelWriteCore(ModelReaderWriterOptions options); | |||
| } | |||
| [Experimental("OPENAI001")] | |||
| public class StreamingResponseTextAnnotationAddedUpdate { | |||
| public class StreamingResponseTextAnnotationAddedUpdate : StreamingResponseUpdate, IJsonModel<StreamingResponseTextAnnotationAddedUpdate>, IPersistableModel<StreamingResponseTextAnnotationAddedUpdate> { | |||
| public BinaryData Annotation { get; } | |||
There was a problem hiding this comment.
Any chance this could be parsed as an ResponseMessageAnnotation ?
gaspardpetit
reviewed
Jul 3, 2025
| @@ -4326,7 +4326,16 @@ public class StreamingResponseRefusalDoneUpdate : StreamingResponseUpdate, IJson | |||
| protected override StreamingResponseUpdate PersistableModelCreateCore(BinaryData data, ModelReaderWriterOptions options); | |||
| protected override BinaryData PersistableModelWriteCore(ModelReaderWriterOptions options); | |||
| } | |||
| public class StreamingResponseTextAnnotationAddedUpdate { | |||
| public class StreamingResponseTextAnnotationAddedUpdate : StreamingResponseUpdate, IJsonModel<StreamingResponseTextAnnotationAddedUpdate>, IPersistableModel<StreamingResponseTextAnnotationAddedUpdate> { | |||
| public BinaryData Annotation { get; } | |||
There was a problem hiding this comment.
Same here, ideally this would be parsed as a ResponseMessageAnnotation
KrzysztofCwalina
approved these changes
Jul 3, 2025
jsquire
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error in code generation that caused the
StreamingResponseTextAnnotationAddedUpdateclass to not be generated correctly as part of the set of possible handles for streaming Responses.