Fixes to Assistant, VectorStore client methods #70

trrwilson · 2024-06-18T01:48:00Z

Fixes GetAssistantAsync does not return a useful value #62 -- the remaining convenience methods in AssistantClient and VectorStoreClient have optional CancellationTokens added as method parameters, including the typed instance convenience overloads
Closes GetRunStepsAsync does not yet take a CancellationToken parameter #61 -- adds missing [EditorBrowsable(EditorBrowsableState.Never)] attributes to AssistantClient protocol methods, improving strongly typed convenience method discoverability
Addresses a yet-unreported problem with the new max_num_results property for file_search not being serialized/deserialized

api/api.md

trrwilson requested a review from KrzysztofCwalina June 18, 2024 01:48

KrzysztofCwalina reviewed Jun 18, 2024

View reviewed changes

api/api.md Outdated Show resolved Hide resolved

trrwilson mentioned this pull request Jun 24, 2024

GetAssistantAsync does not return a useful value #62

Closed

joseharriaga reviewed Jul 9, 2024

View reviewed changes

api/api.md Show resolved Hide resolved

joseharriaga approved these changes Jul 9, 2024

View reviewed changes

refresh

8c994fa

trrwilson force-pushed the user/travisw/2024-06-17-assistant-fixes branch from e632c23 to 8c994fa Compare July 22, 2024 21:33

joseharriaga approved these changes Jul 23, 2024

View reviewed changes

Merge branch 'main' into user/travisw/2024-06-17-assistant-fixes

9f1ed10

trrwilson merged commit d77539c into main Jul 23, 2024
1 check passed

trrwilson deleted the user/travisw/2024-06-17-assistant-fixes branch July 23, 2024 15:33

Provide feedback