Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran govanish linter and it found one suspicious place:
Indeed, as
IsNull()
combine both explicit null and missing case, branchIsMissing()
were redundant in the previous order of conditions - so compiler removed it from the code.This looks like a bug - one possible fix is to properly treat
Missing
case by changing the order of conditions. But maybe there is a better (and safer - can this fix break compatibility?) fix. So feel free to close this PR.