Log the remaining retries info at info log level
#2460
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
I've made some changes to log the remaining requests count at the
infolevel so developers don't have to set their log level todebugand see unnecessary fluff for this simple piece of information. Specifically, changes were made to logs inSyncAPIClient._sleep_for_retryandAsyncAPIClient._sleep_for_retry.I've tested this locally with
examples/demo.pywithOPENAI_LOGset toinfoand seems to work fine.Additional context & links
This fixes #2404
Note: I am not sure if this was meant to be generated or hand-edited, please let me know if I can do anything about it.