Normalize the ordinal "ninth" to "9th" - #2805
Open
iammcoding wants to merge 2 commits into
Open
Conversation
The English number normalizer builds ordinal words by adding "th" to the cardinal word, with a few hardcoded exceptions (first, second, third, fifth, eighth, twelfth). "nine" was missing from those exceptions, so the rule produced "nineth", which nobody writes, and the real word "ninth" was never recognized. As a result "ninth" was left as text instead of "9th", and compound ordinals broke: "twenty ninth" came out as "20 ninth" and "one hundred and ninth" as "100 and ninth". Added "ninth" to the hardcoded ordinals and excluded 9 from the generated rule. Added tests for the simple and compound cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The English number normalizer builds ordinal words by adding "th" to the cardinal word, with a few hardcoded exceptions (first, second, third, fifth, eighth, twelfth). "nine" was missing from those exceptions, so the rule produced "nineth", which nobody writes, and the real word "ninth" was never recognized.
As a result "ninth" was left as text instead of "9th", and compound ordinals broke: "twenty ninth" came out as "20 ninth" and "one hundred and ninth" as "100 and ninth".
Added "ninth" to the hardcoded ordinals and excluded 9 from the generated rule. Added tests for the simple and compound cases.