Add newer PyTorch versions to the test matrix - #2824
Open
Yigtwxx wants to merge 1 commit into
Open
Conversation
The matrix stops at PyTorch 2.5.1 (November 2024), so there is no coverage of the releases most users are on today. Add three rows spanning the gap: - 2.6.0, the release that flipped the `torch.load` default to `weights_only=True` - 2.9.1, mid-gap - 2.13.0, current latest Existing rows are left untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The test matrix stops at PyTorch 2.5.1, released in November 2024. PyTorch is
now at 2.13.0, so there is no CI coverage for any of the releases most users
actually install, including 2.6.0 — the release that changed the
torch.loaddefault to
weights_only=True.Change
Three rows added to
.github/workflows/test.yml, spanning the gap:torch.loadweights_only=Truedefault flipCPU wheels for all three combinations exist on
download.pytorch.org/whl/cpu,so the existing install line works unchanged.
Existing rows are untouched, the pinned action SHAs are untouched, and
pyproject.tomlis untouched.Evidence
The full 12-row matrix was run on this branch before opening the PR:
https://github.com/Yigtwxx/whisper/actions/runs/30698476999
All 13 jobs pass, including the three added rows:
whisper-test (3.12, 2.6.0, 'numpy')whisper-test (3.13, 2.9.1, 'numpy')whisper-test (3.13, 2.13.0, 'numpy')The nine pre-existing rows and
pre-commitalso pass unchanged, so nothing inwhisper/needs to change to support these releases.Note
This is deliberately limited to PyTorch versions. #2657 proposes the Python 3.14
row separately, so that is left out of scope here.