docs(spindle-ui): add design doc for buttonSwitch #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 231d346): https://ameba-spindle--pr1243-feat-button-switch-d-1wnukbwb.web.app (expires Sat, 12 Apr 2025 08:23:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e7521619a2dd5c653490c8246e81ec2a5c8f1435 |
|
✨✨ That's perfect, there is no visual difference! ✨✨ Check out the report here. |
yasuda-shin
reviewed
Mar 11, 2025
| </div> | ||
| ``` | ||
|
|
||
| ## アクセシビリティ |
There was a problem hiding this comment.
も加えてもよさそうに思いました。
| - [ ] ボタンスイッチをラップしているdiv要素に`role="group"`、選択中のボタンに`aria-pressed="true"`を付与している | ||
| - [ ] スクリーンリーダーでも機能落ちがなく、読み上げが過不足なく行われている | ||
|
|
||
| ## リンク集 |
kc7891
reviewed
Mar 11, 2025
| label: string; | ||
| value: string; | ||
| }[]; | ||
| onChange: (value: string | null) => void; |
There was a problem hiding this comment.
Suggested change
| onChange: (value: string | null) => void; | |
| onChange: (value: string) => void; |
口頭で話した通り、利用側でNeutral化するで良さそうです 🙋♂️
kc7891
reviewed
Mar 13, 2025
| <button | ||
| type="button" | ||
| aria-pressed="true" | ||
| class="spui-ButtonSwitch--button" |
There was a problem hiding this comment.
Suggested change
| class="spui-ButtonSwitch--button" | |
| class="spui-ButtonSwitch-button" |
kc7891
reviewed
Mar 13, 2025
| <button | ||
| type="button" | ||
| aria-pressed="false" | ||
| class="spui-ButtonSwitch--button" |
There was a problem hiding this comment.
Suggested change
| class="spui-ButtonSwitch--button" | |
| class="spui-ButtonSwitch-button" |
kc7891
reviewed
Mar 13, 2025
| type="button" | ||
| aria-pressed="true" | ||
| class="spui-ButtonSwitch--button" | ||
| data-value="option1" |
kc7891
reviewed
Mar 13, 2025
| - Surface Quaternary (ホバー時の背景色) | ||
| - Surface Accent Primary (選択時の背景色) | ||
| - Text High Emphasis Inverse (選択時のテキスト色) | ||
| - Border Row Empasis (中央のボーダー色) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新規コンポーネント
ButtonSwitchのDesign Docです。