Fix: /homekit/accessories returns null when characteristic metadata contains NaN or Infinity#2
Open
DarkStarDS9 wants to merge 1 commit intoopenclaw:mainfrom
Open
Conversation
… Infinity JSONEncoder throws EncodingError.invalidValue for NaN/Infinity doubles, causing the accessories endpoint to silently return null via try?. Map these to JSON null instead so /homekit/accessories encodes correctly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GET /homekit/accessoriessilently returnsnullinstead of the expected JSON array, causingcasa devicesto fail with "The data couldn't be read because it isn't in the correct format."Root Cause
JSONEncoderthrowsEncodingError.invalidValuewhen encodingDouble.nanorDouble.infinity— both of which can appear in HomeKit characteristic metadata (e.g.minValue,maxValue,stepValue). TheencodedData()method usedtry?which silently swallowed the error and fell back toData("null".utf8).Fix
In
HomeKitMapper.jsonValue(_:), check for NaN/Infinity before returning.number(...)and map them to.nullinstead:Testing
GET /homekit/accessoriesnow returns a valid JSON envelope with the full accessories arraycasa devicesworks correctly🤖 Generated with Claude Code