feat: add publisher feed query and delta state - #3116
Conversation
|
Someone is attempting to deploy a commit to the OpenClaw Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
Codex review: needs real behavior proof before merge. Reviewed July 22, 2026, 1:32 AM ET / 05:32 UTC. Summary Reproducibility: not applicable. as a defect report: this PR proposes a new publisher-feed query and delta capability rather than repairing an established broken behavior. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review detailsBest possible solution: Confirm the publisher-feed contract and stack order, land the foundation in dependency order, then demonstrate the complete publisher publication, query/change, reset, retention, and upgrade path against a real Convex deployment before merging. Do we have a high-confidence way to reproduce the issue? Not applicable as a defect report: this PR proposes a new publisher-feed query and delta capability rather than repairing an established broken behavior. Is this the best way to solve the issue? Unclear: durable change state is a plausible foundation, but the best solution depends on maintainer acceptance of the still-open parent, RFC-aligned contract, and intended landing order. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against a9775fc39b10. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (1 earlier review cycle)
|
ead5260 to
5e0f848
Compare
9f6ec46 to
37f2745
Compare
|
This pull request has been automatically marked as stale due to inactivity. |
|
Closing due to inactivity. |
Summary
Adds the durable publisher-feed query and changed-since foundation defined by RFC 0009.
Stack
This PR intentionally exposes no unsigned public query or delta endpoint.
Storage
Adds:
publisherFeedRevisions: one row per accepted contiguous revisionpublisherFeedChanges: one row per metadata replacement, complete entry upsert, or removal tombstonecumulativeChangeCounton current publications for upgrade-safe baseline establishmentThe current snapshot remains in
publisherFeedPublications. All revision/change writes occur in the same Convex mutation as snapshot publication.Validation
bun x vitest run packages/schema/src/accountFeed.test.ts convex/accountFeeds.test.ts convex/lib/retentionPolicy.test.ts(24 tests)bun x tsc -p packages/schema/tsconfig.json --noEmitbun x tsc --noEmitbun run lintbun x knip@6.8.0oxfmt --checkgit diff --checkcodex review --uncommitted; final pass found no discrete correctness, security, or maintainability defectsThe full local
ci:staticwrapper stops on pre-existing formatter drift in rootCLAUDE.mdfiles outside this branch; all changed files pass targeted formatting.