Fxing an issue removal of the registry path#434
Open
Shahafgo wants to merge 1 commit intoopenclaw:mainfrom
Open
Fxing an issue removal of the registry path#434Shahafgo wants to merge 1 commit intoopenclaw:mainfrom
Shahafgo wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Contributor
|
@Shahafgo is attempting to deploy a commit to the Amantus Machina Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Attaching issue explanation: #433 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
Fixed URL construction to preserve registry base paths when the registry is hosted at a non-root path (e.g.,
http://host/custom/registry/path). Previously,new URL('/api/v1/skills', 'http://host/base')would discard/basebecause absolute paths override the base URL's path component. The newregistryUrl()helper normalizes both arguments to construct relative URLs, ensuringhttp://host/base/api/v1/skills.registryUrl()helper function inhttp.tswith proper path normalizationinspect.ts,moderation.ts, andskills.tsto use the new helperhttp.test.tscovering plain origins, custom base paths, trailing slashes, and encoded segmentsmoderation.tsto pass complete URLs instead of pathname-only strings to maintain base path contextConfidence Score: 5/5
Last reviewed commit: 8401d0d
(2/5) Greptile learns from your feedback when you react with thumbs up/down!