Conversation
Contributor
|
@Liknox is attempting to deploy a commit to the Amantus Machina Team on Vercel. A member of the Team first needs to authorize it. |
fde567c to
897f090
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: preserve registry base path when hosted at non-root URL
Introduced
registryUrl()helper in http.ts that correctly joins base URL(with possible custom path) and endpoint path, preventing loss of base path
when using
new URL()with absolute paths.Main changes:
registryUrl()helper with proper path normalizationCloses bug where
/basepart was being dropped when constructing API URLsagainst registries hosted at non-root paths (e.g. http://example.com/custom/registry/api/v1/skills)
Test coverage: comprehensive
Risk: low
Greptile Summary
This PR correctly fixes a URL construction bug where registry base paths were being dropped when hosted at non-root URLs. The
registryUrl()helper properly normalizes paths by ensuring the base URL has a trailing slash and the relative path doesn't have a leading slash before constructing the URL, which prevents the URL constructor from treating the path as absolute.Confidence Score: 5/5
Last reviewed commit: fde567c
(2/5) Greptile learns from your feedback when you react with thumbs up/down!