fix(ci): release throttled live-item checks for delayed retry - #1002
Merged
Conversation
clawsweeper
Bot
added
rating: 🧂 unranked krab
Contributor
|
Codex review: needs real behavior proof before merge. Reviewed August 1, 2026, 9:23 AM ET / 13:23 UTC. ClawSweeper reviewWhat this changesThis PR makes the exact-review workflow release a claimed item for a 20-minute delayed retry when GitHub throttles the live-item lookup, rather than failing the run and spending the item’s review-failure budget. Merge readiness⛔ Blocked until real behavior proof from a real setup is added - 5 items remain Keep this PR open. The narrow workflow change fits the existing delayed-retry protocol and addresses a live automation failure that current Priority: P1 Review scores
Verification
How this fits togetherThe exact-review workflow claims a queued GitHub item, verifies that the item is still live, then performs and publishes a Codex review. The live-item gate determines whether the claim proceeds, completes as a no-op, or is returned to the durable queue for a later retry. flowchart TD
A[Durable exact-review queue] --> B[Claim item lease]
B --> C[Live GitHub item check]
C --> D{Item lookup result}
D -->|Open item| E[Review and publish]
D -->|Missing or closed| F[Complete as no-op]
D -->|Rate limited| G[Release claim with delayed retry]
G --> A
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep the live-item throttle handling narrow, remove the release-owned changelog entry, and add redacted after-fix evidence from a controlled workflow replay that shows the claim completing with Do we have a high-confidence way to reproduce the issue? Yes, source inspection gives a high-confidence current-main path: a rate-limited Is this the best way to solve the issue? Yes for the workflow behavior: reusing the established Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 83fa433a0537. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An 11-run failure burst at 13:12Z (e.g. run 30701241184) failed at "Check live target item state" with installation-token rate-limit 403s. #968 covered throttles at the reservation step, but the live-item check runs earlier and still fails the run — burning each item's 8-attempt review-failure budget on end-of-window API exhaustion.
Fix
The live-item step now recognizes rate-limit stderr (
rate limit exceeded|secondary rate limit|HTTP 429) on the item fetch and releases the claim via the existingadmission_retrypath (#962 machinery: requeue withretry_at+20 min, failure counters untouched). All other fetch errors still fail the step; the 404-missing-item completion is unchanged.Proof
build:all— one pre-existing test appeared red locally purely from staledist/repair).