Test durable review status transitions

[hxy91819]

Purpose

Disposable empty-diff PR used to validate the live durable review status transitions implemented by #645.

The validation will exercise successful replacement, lease interruption, and rejection of a stale conditional comment write. No product change is intended from this PR.

[clawsweeper]

Codex review: found issues before merge. Reviewed August 3, 2026, 5:04 AM ET / 09:04 UTC.

ClawSweeper review

What this changes

The branch adds a four-line documentation fixture intended to trigger live durable-review status transition validation without changing product behavior.

Merge readiness

⚠️ Ready for maintainer review - 4 items remain

This member-owned draft is deliberately a disposable live-validation fixture, not a mergeable product change. Its current four-line document would leave misleading permanent repository content if merged, so it should remain open only until a maintainer confirms the validation result and manually closes or repurposes it.

Priority: P3
Reviewed head: 179929d6326b519fd01269ae325229d2eebcffbe
Owner decision: Required. See Decision needed.

Review scores

Measure	Result	What it means
Overall readiness	🦐 gold shrimp (3/6)	The branch has a coherent operational-validation purpose, but its only artifact is intentionally not suitable for merge.
Proof confidence	🌊 off-meta tidepool	Not applicable: Real behavior proof is not required because this PR only changes files under docs/.
Patch quality	🦐 gold shrimp (3/6)	1 actionable review finding remain.

Verification

Check	Result	Evidence
Real behavior	Not applicable	Not applicable: Real behavior proof is not required because this PR only changes files under docs/.
Evidence reviewed	4 items	Disposable fixture declares itself non-mergeable: The only changed file says it exists solely on the disposable validation PR and is not intended to merge; that makes it unsuitable as permanent documentation. Current main does not retain the fixture: Current main has no docs/durable-review-status-live-validation.md, so merging this branch would introduce a new misleading document rather than reconcile with an existing maintained page. Durable review state remains an actively maintained mainline subsystem: Current main’s durable-comment state logic checks review timestamps and PR-head identity before trusting a newer durable comment, confirming that the fixture targets active review automation rather than a standalone documentation surface.
Findings	1 actionable finding	[P2] Remove the disposable fixture before merge
Security	None	None.

How this fits together

ClawSweeper’s review lane coordinates leases and publishes one durable GitHub review comment per item. The durable-comment state module compares the live comment, report metadata, and current PR head to prevent stale review status from being treated as current.

flowchart LR
  A[Selected GitHub item] --> B[Review lease]
  B --> C[Durable comment state]
  C --> D[Freshness and head checks]
  D --> E[Durable review comment]
  E --> F[Maintainer review status]

Loading

Decision needed

Question	Recommendation
Has the intended live validation completed with evidence sufficient to retire this member-owned disposable draft, or should the fixture be replaced by a focused maintained regression test?	Close after recording validation evidence: Recommended: preserve the successful live-run evidence in the PR discussion or runbook, then close this disposable draft without merging the fixture.

Why: The branch is intentionally non-production and its author is a repository member, so automated cleanup should not close it without an explicit maintainer judgment on the validation outcome.

Before merge

• Remove the disposable fixture before merge (P2) - This file explicitly says it exists only on a disposable validation branch and is not intended to merge. Landing it would leave misleading repository documentation while providing no durable regression coverage; remove it before any merge request, or replace it with a focused test if the live run exposed a gap.
• Resolve merge risk (P1) - Merging the fixture would publish documentation that explicitly says it is disposable and not intended to merge, creating misleading operator guidance without preserving the live-validation evidence.
• Complete next step (P2) - A maintainer must confirm the member-owned live validation outcome and retire or convert the disposable branch; there is no safe code-repair task to dispatch.

Findings

• [P2] Remove the disposable fixture before merge — docs/durable-review-status-live-validation.md:1-4

Agent review details

Security

None.

Review metrics

Metric	Value	Why it matters
Changed surface	1 documentation file; 4 added lines	The entire branch is a non-production fixture, so its stated non-mergeability is decisive before landing.

Merge-risk options

Maintainer options:

1. Retire the disposable fixture (recommended)
   Record the live validation result outside repository documentation and close the draft so the knowingly non-mergeable page cannot land.
2. Turn it into real coverage
   Replace the fixture with a focused regression test only if the live exercise identified durable-review behavior that current automated tests do not cover.
3. Keep the draft for active validation
   Retain the branch only while a maintainer still needs the live validation target and confirms that it will not be merged as-is.

Technical review

Best possible solution:

Keep the durable-review validation evidence in the PR discussion or the established observation runbook, then remove the disposable fixture and close the draft after the maintainer verifies the run.

Do we have a high-confidence way to reproduce the issue?

Not applicable: the branch is a declared live-validation fixture rather than a report of user-facing broken behavior. The four-line diff and PR body establish that no product behavior is being proposed for merge.

Is this the best way to solve the issue?

No: merging the disposable file is not the best solution because it permanently documents a branch-only validation artifact. Closing it after recording the live result, or replacing it with narrow maintained regression coverage if needed, is the safer path.

Full review comments:

• [P2] Remove the disposable fixture before merge — docs/durable-review-status-live-validation.md:1-4
  This file explicitly says it exists only on a disposable validation branch and is not intended to merge. Landing it would leave misleading repository documentation while providing no durable regression coverage; remove it before any merge request, or replace it with a focused test if the live run exposed a gap.
  Confidence: 0.99

Overall correctness: patch is incorrect
Overall confidence: 0.99

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 2d1a40bfa643.

Labels

Label changes:

• add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🌊 off-meta tidepool and patch quality is 🦐 gold shrimp.
• remove rating: 🦪 silver shellfish: Current PR rating is rating: 🦐 gold shrimp, so this older rating label is no longer current.

Label justifications:

• P3: This is internal validation cleanup with no user-facing product behavior change.
• merge-risk: 🚨 other: A clean merge would add permanent documentation that explicitly says it is disposable and not intended to merge.
• rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🌊 off-meta tidepool and patch quality is 🦐 gold shrimp.
• status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action. Not applicable: Real behavior proof is not required because this PR only changes files under docs/.

Evidence

What I checked:

• Disposable fixture declares itself non-mergeable: The only changed file says it exists solely on the disposable validation PR and is not intended to merge; that makes it unsuitable as permanent documentation. (docs/durable-review-status-live-validation.md:4, 179929d6326b)
• Current main does not retain the fixture: Current main has no docs/durable-review-status-live-validation.md, so merging this branch would introduce a new misleading document rather than reconcile with an existing maintained page. (docs/durable-review-status-live-validation.md, 2d1a40bfa643)
• Durable review state remains an actively maintained mainline subsystem: Current main’s durable-comment state logic checks review timestamps and PR-head identity before trusting a newer durable comment, confirming that the fixture targets active review automation rather than a standalone documentation surface. (src/clawsweeper-review-comment-state.ts:436, 2d1a40bfa643)
• Prior review finding remains applicable: The fixture file is unchanged from the previously reviewed head except that main lacks the file entirely; the prior P2 finding to remove it before merge therefore remains unresolved rather than being a late-discovered concern. (docs/durable-review-status-live-validation.md:1, 179929d6326b)

Likely related people:

• Peter Steinberger: Current main refactored the durable review-comment subsystem in a commit that owns the state module governing stale durable-review freshness checks. (role: recent area contributor; confidence: high; commits: 2d1a40bfa643; files: src/clawsweeper-review-comment-state.ts)

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

• Record the live validation result in the PR discussion or established runbook.
• Remove the disposable fixture and close the draft, or replace it with a focused maintained regression test.

Rating scale

Score	Internal tier	Crab rank	Meaning
6/6	S	🦀 challenger crab	Exceptional readiness
5/6	A	🦞 diamond lobster	Very strong readiness
4/6	B	🐚 platinum hermit	Good normal PR; ordinary maintainer review
3/6	C	🦐 gold shrimp	Useful, but confidence is limited
2/6	D	🦪 silver shellfish	Proof or implementation needs work
1/6	F	🧂 unranked krab	Not merge-ready
N/A	NA	🌊 off-meta tidepool	Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

• ClawSweeper keeps one durable marker-backed review comment per issue or PR.
• Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
• A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
• PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
• Maintainers can also comment @clawsweeper review to request a fresh review only.
• Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
• Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
• Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (22 earlier review cycles; latest 8 shown)

• reviewed 2026-08-02T08:54:01.340Z sha 179929d :: found issues before merge. :: [P2] Remove the disposable fixture before merge
• reviewed 2026-08-02T12:47:17.184Z sha 179929d :: found issues before merge. :: [P2] Remove the disposable fixture before merge
• reviewed 2026-08-02T15:25:42.534Z sha 179929d :: found issues before merge. :: [P2] Remove the disposable fixture before merge
• reviewed 2026-08-02T17:35:04.559Z sha 179929d :: found issues before merge. :: [P2] Remove the disposable fixture before merge
• reviewed 2026-08-02T21:03:58.252Z sha 179929d :: found issues before merge. :: [P2] Remove the disposable fixture before merge
• reviewed 2026-08-03T01:07:40.921Z sha 179929d :: found issues before merge. :: [P2] Remove the disposable fixture before requesting merge
• reviewed 2026-08-03T02:50:59.184Z sha 179929d :: found issues before merge. :: [P2] Remove the disposable fixture before requesting merge
• reviewed 2026-08-03T06:40:45.797Z sha 179929d :: found issues before merge. :: [P2] Remove the disposable fixture before requesting merge