feat(dashboard): split OpenClaw Bay publishing lane - #733
Conversation
|
@clawsweeper review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
Codex review: needs real behavior proof before merge. Reviewed July 25, 2026, 3:52 AM ET / 07:52 UTC. ClawSweeper reviewWhat this changesThis PR splits OpenClaw Bay’s result-publication display from deterministic applying work, adds State writer telemetry and recovery-state rendering, and updates the responsive dashboard and its focused tests. Merge readiness⛔ Blocked until real behavior proof is added - 4 items remain Keep this PR open. The dashboard direction is coherent and the supplied checks/tests show no discrete correctness or security defect, but the reported local Crabbox run is not accompanied by inspectable after-fix browser evidence, so real behavior proof remains required before merge. Priority: P3 Review scores
Verification
How this fits togetherOpenClaw Bay is ClawSweeper’s operator dashboard for the exact-review queue. It combines bounded durable queue state with active GitHub workflow-worker data and presents the resulting review, publication, applying, and recovery status to operators. flowchart LR
A[Durable exact-review queue] --> C[Bay projection]
B[Active workflow workers] --> D[Worker classification]
C --> E[Publishing and recovery stages]
D --> F[Applying stage and capacity totals]
E --> G[OpenClaw Bay dashboard]
F --> G
H[Cached health history] --> G
Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Attach redacted, inspectable after-fix browser proof that shows representative Publishing, Applying, Repair Cove, and State writer states from the local Bay demo, then retain the focused queue-projection regression coverage. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR adds an operator-facing dashboard projection rather than repairing a reported failing behavior. The source diff and focused tests define the proposed states, but they do not constitute real browser proof. Is this the best way to solve the issue? Unclear: separating durable publication from active deterministic applying work is a coherent use of the existing queue and worker data, but the best presentation cannot be confirmed until inspectable after-fix browser evidence shows the projected states together. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 01e6976cbe6f. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (3 earlier review cycles) |
1719660 to
8db304c
Compare
8db304c to
0d24884
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
@clawsweeper re-review |
0d24884 to
b211a73
Compare
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: feat(dashboard): split OpenClaw Bay publishing lane This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
Summary
Problem
The batch publisher is intentionally targetless at the GitHub Actions-job level, while its durable state lease owns individual GitHub items. Bay could identify the publisher as a live worker but could not reliably show which items it was applying and writing. That made an item appear to vanish after Publishing.
Implementation
ExactReviewPublicationBatchStore.batch_idinto the public Bay projection, then render the matching item in Applying & writing with the batch owner in its detail label.Data and API boundary
Bay reuses the dashboard's existing
/api/status, cached/api/health-history, and durable exact-review queue state. This change adds no direct GitHub API calls, repository scans, polling loop, retained event history, or mutation.The local browser proof recorded 0 direct GitHub API requests and 0 mutation requests. This remains lighter than the operational Overview: Bay reads the same dashboard status payload and does not independently inspect repositories or GitHub items.
Validation
node --test --test-concurrency=1 test/exact-review-publication-batches.test.ts— 44 passed.node --test --test-concurrency=1 --test-name-pattern="Bay queue projection|OpenClaw Bay is" test/dashboard-worker.test.ts— 4 passed.pnpm run build:dashboardpnpm run lint:dashboardpnpm run lint:scriptspnpm exec oxfmt --check dashboard/bay-page.ts dashboard/exact-review-publication-batches.ts dashboard/exact-review-queue.ts docs/proof/openclaw-bay/run-proof.mjs test/dashboard-worker.test.ts test/exact-review-publication-batches.test.tsgit diff --checkcbx_b6556bb75d4f,mcr.microsoft.com/playwright:v1.60.0-noble) againstb211a730268e04fa9373886ce7b5984dea86909c— 48 assertions, 23 evidence frames, no direct GitHub API requests, no mutations. The checked-in proof runner covers the six-stage layout, Publishing/Applying & writing projection, Repair Cove, telemetry cards, range controls, constrained/portrait layouts, and tide behaviour.The aggregate
pnpm run checkwas also attempted locally. Its only failure was the repository-wideoxfmt --checkgate reporting formatting differences across 493 files, including untouched source and workflow files. This Windows-checkout baseline is outside this UI patch; the six touched files pass the scoped formatter check above.Review closeout
codex review --uncommitted— clean; no actionable correctness findings.codex review --base origin/main— clean; no actionable defects.pnpm run review -- --local-range --target-repo openclaw/clawsweeper --base origin/main—keep_open, medium confidence; one active feature branch item reviewed, with no correctness or security finding. No GitHub comment, label, merge, or hosted workflow was triggered.Risks / rollout
User-facing note
OpenClaw Bay now makes the post-publication holding stage honest and visible: a crustacean stays in Applying & writing while its durable publisher batch owns it, instead of appearing to disappear between Publishing and the terminal pool.