fix(ci): complete event-review publication as superseded when the reviewed branch vanished - #977
Merged
Merged
Conversation
…iewed branch vanished
clawsweeper
Bot
added
rating: 🦪 silver shellfish
Contributor
|
Codex review: needs real behavior proof before merge. Reviewed July 31, 2026, 12:55 PM ET / 16:55 UTC. ClawSweeper reviewWhat this changesThe PR treats known missing-ref errors while synchronizing review artifacts as superseded events, then skips applying those stale artifacts. Merge readiness⛔ Blocked until real behavior proof from a real setup is added - 4 items remain Keep this PR open. The workflow repair is narrowly scoped and consistent with the merged stale-review resilience work, but it needs removal of the release-owned changelog edit and real after-fix workflow proof before merge. Priority: P2 Review scores
Verification
How this fits togetherThe sweep workflow produces review artifacts for queued items, synchronizes its publication checkout, and applies the artifacts to canonical records and GitHub. This change sits between artifact download and application, deciding whether a stale review event is published or completed as a no-op. flowchart LR
A[Queued review event] --> B[Generate review artifacts]
B --> C[Download publication artifacts]
C --> D[Sync publication checkout]
D -->|Branch available| E[Apply artifacts]
D -->|Reviewed branch vanished| F[Superseded no-op]
E --> G[Commit records and sync actions]
F --> H[Successful workflow completion]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Retain the narrowly matched superseded path, remove the release-owned changelog entry, and attach redacted action logs showing that a vanished reviewed branch emits the notice while artifact application is skipped. Do we have a high-confidence way to reproduce the issue? No — the PR identifies two failed runs and current source confirms the exact sync/apply boundary, but no local or attached after-fix run demonstrates the vanished-ref path. Is this the best way to solve the issue? Yes, after the cleanup and proof: recognizing only known missing-ref signatures while preserving failure for other pull errors is the narrowest maintainable solution. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 0ee212e35c1a. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Event reviews of clawsweeper's own PRs fail at "Publish review artifacts → Sync before applying artifacts" when the reviewed head branch is force-pushed or deleted mid-review:
git pull --rebaseerrors with "Your configuration specifies to merge with the ref ... but no such ref was fetched" (runs 30646613269, 30646627620 — both on the same contributor PR batch).The stale review is worthless anyway — the newer head triggers its own review event — so a red run here is pure noise, same family as the #966 head-drift and #968 closed-item cases.
Fix
The sync step captures the pull output; on the vanished-ref signature it emits a notice, sets
superseded=true, and exits 0. "Apply review artifacts" (and everything downstream keyed offartifacts_applied) is gated onsuperseded != 'true'. Any other pull failure still fails the step.Proof