feat: add gateway session maintenance settings UI - #1162
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: needs real behavior proof before merge. Reviewed August 15, 2026, 8:14 AM ET / 12:14 UTC. ClawSweeper reviewWhat this changesThis PR adds a dedicated Session maintenance editor to the Gateway Configuration page and stages its values through the existing configuration patch flow. Merge readiness⛔ Blocked until real behavior proof is added - 8 items remain Keep open for product-direction review. Current Windows Hub already provides a schema-driven editor for nested gateway configuration, so this second editor needs a concrete approved UX gap; current-head Windows save/reload proof is also missing. Likely related person: Ranjesh (high confidence). Priority: P3 Review scores
Verification
How this fits togetherWindows Hub obtains a configuration schema and current values from the connected gateway, then lets operators stage and save edits through an optimistic configuration patch. This PR adds a fixed editor for session retention and disk-cleanup settings alongside the existing schema-driven editor. flowchart LR
A[Gateway configuration schema] --> B[Configuration page]
B --> C[Existing schema-driven editor]
B --> D[New session maintenance editor]
C --> E[Save and validation]
D --> E
E --> F[Gateway configuration patch]
Decision needed
Why: Choosing a second, hard-coded editing surface determines product UX and an ongoing compatibility policy with gateway schema changes; source review cannot establish that preference. Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep one gateway-schema-driven configuration editor unless a maintainer explicitly sponsors a specialized experience with documented gateway-version behavior and direct Windows save/reload proof. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR proposes a new editing surface rather than reporting a failing behavior. A Windows live save/reload remains required merge proof. Is this the best way to solve the issue? No: current main already exposes nested gateway configuration through its schema-driven editor, so a separate fixed editor needs maintainer-approved evidence of a specific UX gap. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against fc9add75eda7. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Summary
mode,pruneAfter,maxEntries,resetArchiveRetention,maxDiskBytes, andhighWaterBytesconfig.patchflowFixes #1161
Validation
git diff --check- passedConfigPage.xamland allResources.reswfiles - passed./build.ps1- blocked on this Linux host (pwshis unavailable; direct execution is not supported)dotnet test ./tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --no-restore- blocked (dotnetis unavailable)dotnet test ./tests/OpenClaw.Tray.Tests/OpenClaw.Tray.Tests.csproj --no-restore- blocked (dotnetis unavailable)Rubber-duck review identified and drove fixes for cross-gateway stale drafts, refresh-overwriting edits, gateway parser parity, archive-retention wording, and localization coverage.
Real behavior proof
Not verified / blocked: this host is Linux and cannot launch the WinUI app. The changed state is covered by source-contract tests, but a current-head Windows screenshot and live save round-trip still need Windows CI or maintainer proof.