Skip to content

fix(setup): avoid duplicate failure message #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RomneyDa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(setup): avoid duplicate failure message #1187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/OpenClaw.SetupEngine.UI/Pages/CompletePage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ protected override void OnNavigatedTo(NavigationEventArgs e)
GatewaySummaryText.Text = (args.ReviewSummary ?? SetupReviewSummaryBuilder.Build(new SetupConfig())).CompletionGatewaySummary;
TitleText.Text = "All set!";
SubtitleText.Text = "OpenClaw is ready to go";
SubtitleText.Visibility = Visibility.Visible;
ErrorCard.Visibility = Visibility.Collapsed;
HelpLink.Visibility = Visibility.Collapsed;
FallbackButton.Visibility = Visibility.Collapsed;
Expand All @@ -47,9 +48,7 @@ protected override void OnNavigatedTo(NavigationEventArgs e)
SuccessIcon.Visibility = Visibility.Collapsed;
FailureIcon.Visibility = Visibility.Visible;
TitleText.Text = "Setup failed";
SubtitleText.Text = helpUrl is null
? args.ErrorMessage ?? "An error occurred during setup"
: "Follow the steps below to resolve the setup issue and retry.";
SubtitleText.Visibility = Visibility.Collapsed;
NodeModeBanner.Visibility = Visibility.Collapsed;
StartupRow.Visibility = Visibility.Collapsed;
SummaryPanel.Visibility = Visibility.Collapsed;
Expand Down
12 changes: 12 additions & 0 deletions tests/OpenClaw.Tray.Tests/AppRefactorContractTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1230,6 +1230,18 @@ public void CompletePage_UsesCompletionArgsForStartupPreference()
Assert.DoesNotContain("StartupToggle.IsOn = true", complete);
}

[Fact]
public void CompletePage_ShowsFailureMessageOnlyInErrorCard()
{
var root = TestRepositoryPaths.GetRepositoryRoot();
var complete = File.ReadAllText(Path.Combine(root, "src", "OpenClaw.SetupEngine.UI", "Pages", "CompletePage.xaml.cs"));

Assert.Contains("SubtitleText.Visibility = Visibility.Visible", complete);
Assert.Contains("SubtitleText.Visibility = Visibility.Collapsed", complete);
Assert.Contains("ErrorText.Text = errorMessage", complete);
Assert.DoesNotContain("SubtitleText.Text = helpUrl is null", complete);
}

[Fact]
public void CompletePage_OffersExactFallbackOnlyThroughTypedCompatibilityPath()
{
Expand Down
Loading