Clarify unavailable Local AI setup states - #1204
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 38fecaf6-8da0-4009-8381-0ba921b8ef57
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: needs changes before merge. Reviewed August 21, 2026, 9:37 PM ET / August 22, 2026, 01:37 UTC. ClawSweeper reviewWhat this changesThis PR adds unavailable-Local-AI guidance, disabled setup choices, shared diagnostics, and accessibility coverage to setup and the Local AI settings page. Regression provenancePossible regression — suspected (reviewed change). No predecessor PR is attributed. Merge readinessKeep open. The prior P1 blocker remains: an unavailable fresh GPU probe disables management of an already-running Local AI runtime, contradicting current-main behavior. Priority: P2 Review scores
Verification
Live VerificationCommand: Result: FAIL (failed) — execution before step 1 Assertions:
How this fits togetherLocal AI eligibility combines the detected Windows GPU and the selected model requirements. Setup and the Local AI hub consume that result to present installation choices, diagnostics, and runtime controls. flowchart LR
A[Windows GPU probe] --> B[Local AI eligibility]
C[Selected model] --> B
B --> D[Unavailable diagnostics]
D --> E[Setup review]
D --> F[Local AI hub]
F --> G[Runtime management actions]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Keep eligibility gating for fresh Local AI setup, but preserve runtime lifecycle, diagnostics, and connection-recovery controls for an already-installed managed runtime, with regression coverage for a failed probe. Do we have a high-confidence way to reproduce the issue? Yes, from source with high confidence: the new test constructs a healthy companion-managed runtime plus an unavailable probe and confirms the affected actions become false. Is this the best way to solve the issue? No. The current approach conflates eligibility for new setup with management of an existing runtime; those states need separate enablement rules. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against ccd64bbb7d68. LabelsLabel justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 38fecaf6-8da0-4009-8381-0ba921b8ef57
|
ClawSweeper's P1 is fixed in #1206. The patch is based on exact head 03c5def, keeps hardware eligibility limited to fresh setup, preserves management of an installed runtime, and includes failed-first coverage plus full build, Shared (3812 passed), Tray (2711 passed), and independent review. Please merge #1206 into this branch, then trigger a fresh ClawSweeper review on #1204. |
Summary
Validation
.\build.ps1 -DevBuild- passed (Shared, CLI, WinNode CLI, SetupEngine, WinUI)dotnet test .\tests\OpenClaw.Shared.Tests\OpenClaw.Shared.Tests.csproj --no-restore- passed: 3,812, skipped: 32, failed: 0dotnet test .\tests\OpenClaw.Tray.Tests\OpenClaw.Tray.Tests.csproj --no-restore- passed: 2,708, failed: 0dotnet test .\tests\OpenClaw.Tray.UITests\OpenClaw.Tray.UITests.csproj --no-restore -r win-arm64- passed: 134, failed: 0Real behavior proof
Current-head commit
03c5deffis running in the isolated setup preview:Live UI Automation confirms the sibling InfoBar renders completely above the disabled Local AI choice and keeps its action enabled:
The InfoBar bottom at 835 is above the Local AI card control beginning at 865. Invoking See why exposes the live hardware reason without enabling the dependent setup choice:
Available and unavailable projection behavior is also covered by
LocalAiPageViewModelTests; XAML placement, built-in InfoBar message/action layout, badge icon/state, disabled controls, and action separation are covered byLocalAiSetupUxContractTests; the real WinUI accessibility suite passed on ARM64.Screenshots: Not verified / blocked. No computer-use tool is exposed in this session. Native
PrintWindowand desktop capture could see the respondingOpenClaw SetupHWND but did not expose the WinUI surface, so no misleading screenshot is attached.