Improve Node capability summary UX - #891
Conversation
Replace the Connection page Node card raw capability dump with stateful capability pills and a collapsed technical-details disclosure. Preserve raw gateway capability, command, and permission details for debugging while improving default scanability, theme handling, and accessibility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Codex review: needs maintainer review before merge. Reviewed June 29, 2026, 8:48 PM ET / 00:48 UTC. Summary Reproducibility: not applicable. this is a PR for a user-facing tray UX improvement rather than a reproducible bug report. The relevant proof path is PR-head UI evidence, and the inspected screenshot shows the changed Node card state. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the focused Connection page UX change after maintainer acceptance and completed checks, preserving raw gateway details behind the expander. Do we have a high-confidence way to reproduce the issue? Not applicable; this is a PR for a user-facing tray UX improvement rather than a reproducible bug report. The relevant proof path is PR-head UI evidence, and the inspected screenshot shows the changed Node card state. Is this the best way to solve the issue? Yes, with maintainer UX review; the implementation stays inside the existing ConnectionPage applicator pattern, preserves raw details for debugging, and does not change protocol, storage, or execution behavior. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against a3c5e0bf6fce. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Move the capability pill automation name onto the visible TextBlock so screen readers can announce the capability label and state through a real text peer instead of relying on a named Border container. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Summary
Change Type (select all)
Scope (select all touched areas)
winnodeLinked Issue/PR
Validation
1e9aa5e3— exposed Node capability pill state through the visible TextBlock automation peer../build.ps1— ✅ all projects built after test-project restore for fresh worktree assets.dotnet test ./tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --no-restore— ✅ 2629 passed / 31 skipped.dotnet test ./tests/OpenClaw.Tray.Tests/OpenClaw.Tray.Tests.csproj --no-restore— ✅ 1433 passed../build.ps1— ✅ all projects builtdotnet test ./tests/OpenClaw.Tray.Tests/OpenClaw.Tray.Tests.csproj --no-restore— ✅ 1432 passeddotnet test ./tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --no-restore— ✅ 2629 passed / 31 skipped401 Unauthorized: Missing bearer or basic authentication); fallback code-review agent found no significant issues.Real behavior proof
5637a479visual proof plus maintainer accessibility patch1e9aa5e3../run-app-local.ps1 -NoBuild -AllowNonMain, then opened Companion Settings → Connection. Maintainer patch used automated source regression testNodeCapabilityPills_ExposeStateThroughReadableTextPeerplus full required validation.Yes/No/N/A): YesSecurity Impact (required)
Yes/No): NoYes/No): NoYes/No): NoYes/No): NoYes/No): NoYes, explain risk + mitigation: N/ACompatibility / Migration
Yes/No): YesYes/No): NoYes/No): NoReview Conversations
If a bot review conversation is addressed by this PR, resolve that conversation yourself. Do not leave bot review conversation cleanup for maintainers.