fix(billychl1/footballbin-predictions): use jq for safe JSON construction#74
Closed
billychl1 wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(billychl1/footballbin-predictions): use jq for safe JSON construction#74billychl1 wants to merge 1 commit intoopenclaw:mainfrom
billychl1 wants to merge 1 commit intoopenclaw:mainfrom
Conversation
|
Thanks for the pull request! This repository is read-only and is automatically synced from https://clawhub.ai, so we can’t accept changes here. Please make updates on the website instead. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a JSON injection vulnerability in
scripts/footballbin.shfor thefootballbin-predictionsskill.Problem
User-supplied inputs (
league,home_team,away_team) were directly interpolated into a JSON string via bash string concatenation:A malicious input like
--home 'x","injected":"y'could break the JSON structure and inject arbitrary fields into the MCP API call.Fix
Use
jq(already declared as a required dependency inSKILL.md) to construct JSON safely with proper escaping:This ensures all user input is properly escaped by
jqbefore being included in the JSON payload.