Skip to content

Conversation

@dfulu
Copy link
Member

@dfulu dfulu commented Sep 27, 2023

Pull Request

Description

Add ramp rate metric.

Note this pull request can't easily be tested until after the Passiv data changes are added, so is left as a draft for now.

Notes:

  • Since GSPs have very different capacities, we calculate ramp rate on the normalised truth and prediction values
  • The ramp rate calculated is between the 60- and 120-minute horizons
  • Ramp rate is expressed in units of: Change in percentage of GSP capacity per hour
  • The metric added is the MAE of the true and predicted ramp rates
  • Calculated on the model's prediction of the median value

Fixes #

How Has This Been Tested?

Will be tested locally, after

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@dfulu dfulu requested a review from zakwatts September 27, 2023 12:32
@codecov
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #86 (afae5d2) into main (2dd1cc9) will decrease coverage by 0.25%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   49.87%   49.63%   -0.25%     
==========================================
  Files          23       23              
  Lines        1644     1652       +8     
==========================================
  Hits          820      820              
- Misses        824      832       +8     
Files Coverage Δ
pvnet/models/base_model.py 32.11% <0.00%> (-1.23%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@Sukh-P
Copy link
Member

Sukh-P commented Jul 21, 2025

@dfulu just looking at open PRs we have, this one still relevant or worth closing?

@dfulu
Copy link
Member Author

dfulu commented Jul 21, 2025

@dfulu just looking at open PRs we have, this one still relevant or worth closing?

I'm actively working on refactoring and cleaning up PVNet right now. So I'd leave this for the moment and come back to it. I think it is a good metric to have, but I also want to cut down on the huge amount of metrics we are using if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants