Add enableComponentConsoleOutput config to decouple logging from storage location #1465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Closes #1464
Changes
This PR decouples component console logging from the
localconfiguration flag, allowing component logs to be visible regardless of whether the registry serves components from local filesystem or remote storage.cc: @kmcrawford @GinGatt
What Changed
Added
enableComponentConsoleOutputconfiguration option (src/types.ts)falsefor backward compatibilityUpdated options sanitizer (
src/registry/domain/options-sanitiser.ts)Updated component execution context (
src/registry/routes/helpers/get-component.ts)conf.localtoconf.enableComponentConsoleOutputEnabled by default in dev mode (
src/cli/facade/dev.ts)oc devcommand setsenableComponentConsoleOutput: true