Skip to content

[DASH SAI] Add ENI mode VM/FNIC and trusted_vni entry #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

jimmyzhai
Copy link
Collaborator

@jimmyzhai jimmyzhai commented Mar 22, 2025

The related DASH P4 PR: sonic-net/DASH#672

@prsunny
Copy link
Collaborator

prsunny commented Mar 24, 2025

Thanks @jimmyzhai for the PR. @mukeshmv , @marian-pritsak for review

@prsunny
Copy link
Collaborator

prsunny commented Mar 25, 2025

@jimmyzhai , can you also provide global trusted vni range support for appliance table?

@jimmyzhai
Copy link
Collaborator Author

@jimmyzhai , can you also provide global trusted vni range support for appliance table?

Yes, I'm doing it.

@jimmyzhai
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

*
* @objects SAI_OBJECT_TYPE_ENI
*/
sai_object_id_t eni_id;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HLD allows for a global list of trusted VNIs associated with the appliance instead of a specific VNI (https://github.com/sonic-net/SONiC/blob/master/doc/dash/dash-sonic-hld.md#328-appliance), how do we plan to handle this if eni_id is part of the entry definition? @prsunny

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added sai_global_trusted_vni_entry_t

@jimmyzhai
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

sai_bulk_create_eni_trusted_vni_entry_fn create_eni_trusted_vni_entries;
sai_bulk_remove_eni_trusted_vni_entry_fn remove_eni_trusted_vni_entries;

sai_create_global_trusted_vni_entry_fn create_global_trusted_vni_entry;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be better to put global ones in the front.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

2/ Add eni_trusted_vni entry
3/ Add global_trusted_vni entry

Signed-off-by: Junhua Zhai <[email protected]>
@jimmyzhai jimmyzhai marked this pull request as ready for review April 9, 2025 04:56
@jimmyzhai
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny prsunny merged commit 290c475 into opencomputeproject:master Apr 9, 2025
3 checks passed
JaiOCP pushed a commit to JaiOCP/SAI that referenced this pull request May 2, 2025
…OP_PACKETS (opencomputeproject#2158)

2/ Add eni_trusted_vni entry
3/ Add global_trusted_vni entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants