-
Notifications
You must be signed in to change notification settings - Fork 523
[DASH SAI] Add ENI mode VM/FNIC and trusted_vni entry #2158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @jimmyzhai for the PR. @mukeshmv , @marian-pritsak for review |
@jimmyzhai , can you also provide global trusted vni range support for appliance table? |
Yes, I'm doing it. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
* | ||
* @objects SAI_OBJECT_TYPE_ENI | ||
*/ | ||
sai_object_id_t eni_id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The HLD allows for a global list of trusted VNIs associated with the appliance instead of a specific VNI (https://github.com/sonic-net/SONiC/blob/master/doc/dash/dash-sonic-hld.md#328-appliance), how do we plan to handle this if eni_id is part of the entry definition? @prsunny
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added sai_global_trusted_vni_entry_t
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
sai_bulk_create_eni_trusted_vni_entry_fn create_eni_trusted_vni_entries; | ||
sai_bulk_remove_eni_trusted_vni_entry_fn remove_eni_trusted_vni_entries; | ||
|
||
sai_create_global_trusted_vni_entry_fn create_global_trusted_vni_entry; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be better to put global ones in the front.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
2/ Add eni_trusted_vni entry 3/ Add global_trusted_vni entry Signed-off-by: Junhua Zhai <[email protected]>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…OP_PACKETS (opencomputeproject#2158) 2/ Add eni_trusted_vni entry 3/ Add global_trusted_vni entry
The related DASH P4 PR: sonic-net/DASH#672