Bulk get/set for switches #2174

shri-khare · 2025-06-02T00:22:06Z

Bulk get/set for switches

JaiOCP

Looks Good

kcudnik · 2025-06-03T07:44:12Z

/azp run

azure-pipelines · 2025-06-03T07:44:21Z

Azure Pipelines successfully started running 1 pipeline(s).

kcudnik · 2025-06-03T08:01:30Z

Processing saiwred_8h.xml
ERROR: invalid object type SAI_OBJECT_TYPE_SWITCHE extracted from bulk definition: sai_bulk_object_set_attribute_fn       set_switches_attribute
ERROR: invalid object type SAI_OBJECT_TYPE_SWITCHE extracted from bulk definition: sai_bulk_object_get_attribute_fn       get_switches_attribute

please fix build error, take a look what other bulk functions are declared, optionally since object type is extracted from name like "routes" -> "route" then from "switches" -> "switche" and it should be "switch", parser needs to be fixed in this place to correct extract object name, please fix parse.pl somewhere about here: https://github.com/opencomputeproject/SAI/blob/master/meta/parse.pl#L4453, you can add explicit check if its SWITCHE then replace that to SWITCH

shri-khare · 2025-06-04T19:50:25Z

Thanks @kcudnik.

I am unable to locally run make in the meta to reproduce this error, which makes it harder to iterate while fixing. In the past, I could get around this issue by compiling and using old doxygen 1.8.13, but this time around, that did not work either.

Is this workflow documented anywhere? Here the error I hit:

[/local/github/SAI.git/meta: (bulk-get-set-switch)]$ doxygen -V
1.11.0
with sqlite3 3.42.0.

[/local/github/SAI.git/meta: (bulk-get-set-switch)]$ make
GNU Make 4.3
gcc (GCC) 11.5.0 20240719 (Red Hat 11.5.0-5)
This is perl 5, version 32, subversion 1 (v5.32.1) built for x86_64-linux-thread-multi
@(#) International Ispell Version 3.1.20 (but really Aspell 0.60.8)
dot - graphviz version 2.44.0 (0)
doxygen: 1.11.0
GNU nm (GNU Binutils) 2.37
doxygen Doxyfile 2>&1 | perl -npe '$e=1 if /warning/i; END{exit $e}'
warning: Tag 'HTML_TIMESTAMP' at line 1133 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'FORMULA_TRANSPARENT' at line 1413 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'DOT_FONTNAME' at line 2079 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'DOT_FONTSIZE' at line 2086 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'DOT_TRANSPARENT' at line 2280 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
make: *** [Makefile:118: xml] Error 1

Also, pls note, that I have revised the PR with additional code changes.
It should continue to fail with the error though given the code still uses "switches".

shri-khare · 2025-06-04T19:50:29Z

Thanks @kcudnik.

I am unable to locally run make in the meta to reproduce this error, which makes it harder to iterate while fixing. In the past, I could get around this issue by compiling and using old doxygen 1.8.13, but this time around, that did not work either.

Is this workflow documented anywhere? Here the error I hit:

[/local/github/SAI.git/meta: (bulk-get-set-switch)]$ doxygen -V
1.11.0
with sqlite3 3.42.0.

[/local/github/SAI.git/meta: (bulk-get-set-switch)]$ make
GNU Make 4.3
gcc (GCC) 11.5.0 20240719 (Red Hat 11.5.0-5)
This is perl 5, version 32, subversion 1 (v5.32.1) built for x86_64-linux-thread-multi
@(#) International Ispell Version 3.1.20 (but really Aspell 0.60.8)
dot - graphviz version 2.44.0 (0)
doxygen: 1.11.0
GNU nm (GNU Binutils) 2.37
doxygen Doxyfile 2>&1 | perl -npe '$e=1 if /warning/i; END{exit $e}'
warning: Tag 'HTML_TIMESTAMP' at line 1133 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'FORMULA_TRANSPARENT' at line 1413 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'DOT_FONTNAME' at line 2079 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'DOT_FONTSIZE' at line 2086 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'DOT_TRANSPARENT' at line 2280 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
make: *** [Makefile:118: xml] Error 1

shri-khare · 2025-06-05T01:57:49Z

/azp run

azure-pipelines · 2025-06-05T01:57:54Z

Commenter does not have sufficient privileges for PR 2174 in repo opencomputeproject/SAI

tjchadaga · 2025-06-05T05:08:00Z

/azp run

azure-pipelines · 2025-06-05T05:08:09Z

Azure Pipelines successfully started running 1 pipeline(s).

shri-khare · 2025-06-05T15:14:28Z

/azpw run

Signed-off-by: Shrikrishna (Shri) Khare <[email protected]>

shri-khare · 2025-06-05T15:54:16Z

/azpw run

tjchadaga · 2025-06-06T16:26:14Z

/azp run

azure-pipelines · 2025-06-06T16:26:23Z

Azure Pipelines successfully started running 1 pipeline(s).

kcudnik · 2025-06-09T08:06:58Z

can you update your local doxygen ? seems like your is too old and dont support some tags

kcudnik · 2025-06-09T08:07:42Z

In file included from ../inc/sai.h:64,
                 from saisanitycheck.c:28:
../inc/saiswitch.h:4067:1: error: no semicolon at end of struct or union [-Werror]
 4067 | } sai_switch_api_t;
      | ^
cc1: all warnings being treated as errors
make: *** [Makefile:142: saisanitycheck.o] Error 1

shri-khare · 2025-06-10T16:43:44Z

@kcudnik

I built and used the latest doxygen, but local make in meta continues to fail.

$ doxygen --version
1.15.0 (babbc98591ee150adb0e57c5a7f38c4ad95c5624)
$ cd /github/sai.git/meta
$ make
GNU Make 4.3
gcc (GCC) 11.5.0 20240719 (Red Hat 11.5.0-5)
This is perl 5, version 32, subversion 1 (v5.32.1) built for x86_64-linux-thread-multi
@(#) International Ispell Version 3.1.20 (but really Aspell 0.60.8)
dot - graphviz version 2.44.0 (0)
doxygen: 1.15.0 (babbc98591ee150adb0e57c5a7f38c4ad95c5624)
GNU nm (GNU Binutils) 2.37
doxygen Doxyfile 2>&1 | perl -npe '$e=1 if /warning/i; END{exit $e}'
warning: Tag 'HTML_TIMESTAMP' at line 1133 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'FORMULA_TRANSPARENT' at line 1413 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'DOT_FONTNAME' at line 2079 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'DOT_FONTSIZE' at line 2086 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
warning: Tag 'DOT_TRANSPARENT' at line 2280 of file 'Doxyfile' has become obsolete.
To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
make: *** [Makefile:118: xml] Error 1

kcudnik · 2025-06-12T07:41:54Z

then new support needs to be added for that version, since some of the fields in config are obsolete and causing warnings

kcudnik · 2025-06-12T07:42:40Z

as a quick fix you can comment those configs in Doxygen and Doxygen.compat file which are causing errors

tjchadaga · 2025-07-02T21:05:17Z

@shri-khare - were you able to try the workaround that Kamil suggested? Please let us know if this is still an issue

shri-khare force-pushed the bulk-get-set-switch branch 2 times, most recently from 95af4c8 to 0ea3df1 Compare June 2, 2025 00:26

shri-khare marked this pull request as ready for review June 2, 2025 21:12

JaiOCP approved these changes Jun 2, 2025

View reviewed changes

shri-khare force-pushed the bulk-get-set-switch branch from 0ea3df1 to 8f262b4 Compare June 4, 2025 19:43

shri-khare force-pushed the bulk-get-set-switch branch 2 times, most recently from 4c1dfb7 to dadd821 Compare June 5, 2025 01:55

shri-khare force-pushed the bulk-get-set-switch branch from dadd821 to 33722d4 Compare June 5, 2025 15:53

Bulk get/set for switches

ae5963d

Signed-off-by: Shrikrishna (Shri) Khare <[email protected]>

shri-khare force-pushed the bulk-get-set-switch branch from 33722d4 to ae5963d Compare June 5, 2025 15:53

rajkumar38 approved these changes Jun 5, 2025

View reviewed changes

tjchadaga added the reviewed PR is discussed in SAI Meeting label Jun 6, 2025

Bulk get/set for switches #2174

Are you sure you want to change the base?

Bulk get/set for switches #2174

Uh oh!

Conversation

shri-khare commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JaiOCP left a comment

Choose a reason for hiding this comment

Uh oh!

kcudnik commented Jun 3, 2025

Uh oh!

azure-pipelines bot commented Jun 3, 2025

Uh oh!

kcudnik commented Jun 3, 2025

Uh oh!

shri-khare commented Jun 4, 2025

Uh oh!

shri-khare commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shri-khare commented Jun 5, 2025

Uh oh!

azure-pipelines bot commented Jun 5, 2025

Uh oh!

tjchadaga commented Jun 5, 2025

Uh oh!

azure-pipelines bot commented Jun 5, 2025

Uh oh!

shri-khare commented Jun 5, 2025

Uh oh!

shri-khare commented Jun 5, 2025

Uh oh!

tjchadaga commented Jun 6, 2025

Uh oh!

azure-pipelines bot commented Jun 6, 2025

Uh oh!

kcudnik commented Jun 9, 2025

Uh oh!

kcudnik commented Jun 9, 2025

Uh oh!

shri-khare commented Jun 10, 2025

Uh oh!

kcudnik commented Jun 12, 2025

Uh oh!

kcudnik commented Jun 12, 2025

Uh oh!

tjchadaga commented Jul 2, 2025

Uh oh!

Uh oh!

shri-khare commented Jun 2, 2025 •

edited

Loading

shri-khare commented Jun 4, 2025 •

edited

Loading