Skip to content

SAI PTP Enhancements #2205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SAI PTP Enhancements #2205

wants to merge 1 commit into from

Conversation

archis001-marvell
Copy link

Following SAI PTP enhancements are proposed to:-

  • Apply PTP Time Offset Adjustment
  • Apply PTP Syntonization Adjustment
  • Configure PTP Peer Mean Path Delay
  • Configure Hostif Trap for PTP Peer Delay Messages

@archis001-marvell archis001-marvell force-pushed the amaitra_ptp branch 4 times, most recently from a668977 to b922694 Compare September 11, 2025 12:21
rlhui
rlhui reviewed Sep 11, 2025
View reviewed changes
@rlhui rlhui added the reviewed PR is discussed in SAI Meeting label Sep 15, 2025
@tjchadaga
Copy link
Collaborator

@archis001-marvell - could you please resolve branch conflicts?

@tjchadaga
Copy link
Collaborator

@itaibaz, @bandaru-viswanath - could you please help review?

@archis001-marvell
Copy link
Author

@archis001-marvell - could you please resolve branch conflicts?

Done

@tjchadaga
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tjchadaga
Copy link
Collaborator

@archis001-marvell - could you please address the metadata check failure? Also, please squash your commits

WARNING: line ends in whitespace saiport.h 2726:     
WARNING: Header doesn't meet style requirements (most likely ident is not 4 or 8 spaces) saiport.h 2726:    
WARNING: line ends in whitespace saiswitch.h 3491:     
WARNING: Header doesn't meet style requirements (most likely ident is not 4 or 8 spaces) saiswitch.h 3491:

@archis001-marvell archis001-marvell marked this pull request as draft October 10, 2025 06:05
@archis001-marvell archis001-marvell marked this pull request as ready for review October 10, 2025 07:35
@archis001-marvell archis001-marvell marked this pull request as draft October 10, 2025 08:02
@archis001-marvell archis001-marvell force-pushed the amaitra_ptp branch 3 times, most recently from 6158814 to f4b5f05 Compare October 10, 2025 08:16
@archis001-marvell archis001-marvell marked this pull request as ready for review October 10, 2025 08:16
@archis001-marvell
Copy link
Author

@archis001-marvell - could you please address the metadata check failure? Also, please squash your commits

WARNING: line ends in whitespace saiport.h 2726:     
WARNING: Header doesn't meet style requirements (most likely ident is not 4 or 8 spaces) saiport.h 2726:    
WARNING: line ends in whitespace saiswitch.h 3491:     
WARNING: Header doesn't meet style requirements (most likely ident is not 4 or 8 spaces) saiswitch.h 3491:

Done. I was getting into a rebase and conflict issue with remote, now fixed. Thanks.

@archis001-marvell
SAI PTP Enhancements
315ba22 
Signed-off-by: Archisman Maitra <[email protected]>
@archis001-marvell
Copy link
Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 2205 in repo opencomputeproject/SAI

@tjchadaga
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tjchadaga
Copy link
Collaborator

@itaibaz - gentle reminder on this. Could you please help review/sign-off on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rlhui rlhui rlhui left review comments

Assignees

No one assigned

Labels

reviewed PR is discussed in SAI Meeting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@archis001-marvell @tjchadaga @rlhui