Caption date formats and an optional camera/lens line#47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38.
Two caption upgrades, both leaning into the EXIF/metadata moat.
Date format — the date caption was locked to "Month Year". Now there's a picker: Month Year, Full date, or Year. Changing it reflows the auto dates on existing photos, but never touches a caption you typed yourself (
isAutoDateonly matches strings that equal one of the auto formats for that photo's capture time, which is whytakenAtis now kept on the model).Camera info line — an optional muted line under the date with body + lens + exposure pulled from EXIF, e.g.
Nikon D7000 · 35mm · f/2.8 1/200s ISO400. Off by default. Rendered in the editor, the sheet preview, and the PDF (truncated to fit the card).Changes
date.ts:DATE_FORMATS, formatter per format,isAutoDate.exif.ts: reads Make/Model/LensModel/FNumber/ExposureTime/ISO/FocalLength → one-line summary.dateFormat+showCameraLinesettings (persisted);takenAt+cameraLineon the photo (persisted).applyDateFormatstore action mirrorsapplyLocationMode.Verification
11/11 headless assertions on the date logic: all three formats render correctly and
isAutoDateflags every auto string while leaving custom captions untouched. typecheck / oxlint / build green.