Per-page frame shape and per-frame border colour#62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two finer-grained overrides on top of the sheet-level defaults.
Per-page shape. Each page now carries its own shape. Next to "Page X of Y" there's a square/tall/wide toggle (the icons from the old inspector) — flip a page and only that page changes; the photos re-flow because a tall page holds fewer frames. When pages disagree, the right-rail Frame dropdown reads Mixed; pick a shape there and it applies to every page and clears the per-page overrides. New
lib/pages.tspaginate()walks photos with per-page capacity and is shared by the preview and the PDF, so multi-shape sheets export correctly.Per-frame border colour. The floating inspector gains a swatch row (white/cream/black/pink/coral/sky) plus a reset that drops back to the sheet colour. It overrides just the selected frame; captions still flip light/dark for contrast. Stored on the photo (so it survives reload and travels in the project file) and mirrored in the PDF.
The sheet-level Frame/Border defaults in the right rail are unchanged — these just let you deviate per page and per frame.
Verified live: page 1 → Tall flips that page and the dropdown shows Mixed; a coral border on one frame leaves its neighbours white with captions staying legible.