allow numpy 2.3 #1142
Open
allow numpy 2.3 #1142
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup.py
Outdated
| @@ -26,7 +26,7 @@ def main(): | |||
| # see https://numpy.org/doc/stable/release/2.3.0-notes.html#numpy-2-3-0-release-notes | |||
| install_requires = [ | |||
| 'numpy<2.0; python_version<"3.9"', | |||
| 'numpy(>=2, <2.3.0); python_version>="3.9"', | |||
| 'numpy(>=2, <2.4.0); python_version>="3.9"', | |||
There was a problem hiding this comment.
- just
numpy>=2 - drop comment above this section
We should not push unnecessary locks on user environment.
@asmorkalov CI environment should be pinned instead (if necessary - probably not).
There was a problem hiding this comment.
Thanks! Updated to >2 in 7bd1825
braingram
force-pushed
the
unpin_numpy
branch
from
fbcf29e to
95f2778
Compare
braingram
force-pushed
the
unpin_numpy
branch
from
95f2778 to
7bd1825
Compare
|
This would be good to have considering python 3.14 is around the corner and numpy 2.3.x adds support for that version. Currently, opencv users cannot test against python 3.14 (easily). I found this out today when trying to setup some 3.14 canary pipelines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes the runtime numpy dependency to allow the latest released minor version (2.3.x).
This follows the recommendations linked in #1119 (which added the runtime upper pin) and updates the pin based on the latest released version.EDIT: see #1142 (comment) for discussion on pinissue #1140 #1135