Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enabled the CUDA cascade classifier support using the openCV4.x Fi… #2554

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Re-enabled the CUDA cascade classifier support using the openCV4.x Fi… #2554

merged 2 commits into from
Jun 11, 2020

Conversation

nosajthenitram
Copy link
Contributor

@nosajthenitram nosajthenitram commented Jun 1, 2020 •
edited by alalek
Loading

…leStorage API.

#2048

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • [y ] I agree to contribute to the project under OpenCV (BSD) License.
  • [y ] To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • [y ] The PR is proposed to proper branch
  • [y ] There is reference to original bug report and related work
  • [n/a ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • [y ] The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
buildworker:Custom=linux-4
build_image:Custom=ubuntu-cuda:16.04

@alalek
Copy link
Member

alalek commented Jun 8, 2020

Thank you for the contribution!

Could you please re-enable tests in modules/cudaobjdetect/test/test_objdetect.cpp (see 43ab2d8 ) and try to run them?

@nosajthenitram
Re-enabled the CUDA cascade classifier tests.
ff3ebae 
Removed line of disabled code from cascade read.
@nosajthenitram
Copy link
Contributor Author

Updated the opencv_test_cudaobjdetect tests and opencv_test_cudalegacy tests to run the disabled tests. All of the relevant tests pass.

@nosajthenitram nosajthenitram mentioned this pull request Jun 10, 2020
Closed
1 task
alalek
alalek approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for the contribution 👍

@alalek alalek merged commit 39ced2a into opencv:master Jun 11, 2020
@emgucv emgucv mentioned this pull request Jun 11, 2020
Open
philippefoubert pushed a commit to philippefoubert/opencv_contrib that referenced this pull request Jun 20, 2020
@nosajthenitram @philippefoubert
Merge pull request opencv#2554 from nosajthenitram:2048_cuda_cascade_…
0ad7d85 
…no_longer_available

* Re-enabled the CUDA cascade classifier support using the openCV4.x FileStorage API.

* Re-enabled the CUDA cascade classifier tests.

Removed line of disabled code from cascade read.
@atinfinity atinfinity mentioned this pull request Nov 16, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels
category: cuda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nosajthenitram @alalek