Skip to content

Use git dependency for opendata instead of path #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hachikuji merged 1 commit into from
Feb 5, 2026
Merged

Use git dependency for opendata instead of path #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ jobs:
- name: Checkout opendata-java
uses: actions/checkout@v4

- name: Checkout opendata
run: git clone --depth 1 https://github.com/opendata-oss/opendata.git ../opendata

- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@stable

Expand Down
8 changes: 3 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,12 @@ Prerequisites:
- Rust toolchain
- Java 17+
- Maven 3.8+
- Local clone of [opendata](https://github.com/opendata-oss/opendata) as sibling directory

```bash
# Build native library
# Build native library (fetches opendata dependency via git automatically)
cd log/native
cargo build --release

# Build Java modules
# Build and test Java modules
cd ../..
mvn clean install
mvn verify -Djava.library.path=log/native/target/release
```
2 changes: 2 additions & 0 deletions log/native/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 2 additions & 9 deletions log/native/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,5 @@ jni = "0.21"
bytes = "1"
tokio = { version = "1", features = ["rt-multi-thread", "sync", "time"] }

# Local path to opendata crates (sibling directory)
# Assumes: ../opendata/ and ../opendata-java/ are siblings
[dependencies.log]
package = "log"
path = "../../../opendata/log"

[dependencies.common]
package = "common"
path = "../../../opendata/common"
log = { git = "https://github.com/opendata-oss/opendata.git" }
common = { git = "https://github.com/opendata-oss/opendata.git" }