Attempt to get docker image building on a GDAL 3.9 base. #1587
Conversation
for more information, see https://pre-commit.ci
| --no-binary rasterio | ||
| --no-binary fiona | ||
| --no-binary shapely | ||
| --no-binary cf-units |
There was a problem hiding this comment.
Pyproj seems to be installing fine from pip without --no-binary - I only added them if the binary wheel didn't work.
There was a problem hiding this comment.
my suggestion is don't bother with non-conda installs, but this looks like your gdal is missing netcdf support OR your build stage has more libs than your use stage.
conda envs are somewhat larger than pip, but at least you don't have that nightmare to deal with. Alternatively go all out and build EVERYTHING from source and stop mixing pre-compiled things from pip with locally compiled code.
There was a problem hiding this comment.
Now I've got it working we'll probably stick with this for the short term. In the longer term, @omad has ideas for a long overdue complete restructure the way tests are run in github (including dropping docker all together). An Issue will be created soon.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1587 +/- ##
===========================================
- Coverage 91.79% 91.78% -0.01%
===========================================
Files 132 132
Lines 14633 14633
===========================================
- Hits 13432 13431 -1
- Misses 1201 1202 +1 ☔ View full report in Codecov by Sentry. |
| @@ -853,9 +853,6 @@ def multipoint(coords: CoordList, crs: MaybeCRS) -> Geometry: | |||
| """ | |||
| Create a 2D MultiPoint Geometry | |||
|
|
|||
| >>> multipoint([(10, 10), (20, 20)], None) | |||
| Geometry(MULTIPOINT (10 10, 20 20), None) | |||
|
|
|||
There was a problem hiding this comment.
This test fails - looks like shapely has changed the str representation of multipoint geometries.
Reason for this pull request
The latest osgeo/gdal/ubuntu base images use Ubuntu 24.04 with Python 3.12 and GDAL 3.9
This requires a pretty major uplift of our test docker image build.
Edit: That was a nightmare, but seeing as I actually got working we will run with it at least in the short-term. In the longer term a complete rewrite with something simpler and more maintainable is being discussed.
Proposed changes
Added minimum versions for a number of packages that have only recently become Python 3.12 compatible.
Manually build (
--no-binary) wheels for packages which need to link to GDAL or otherwise do not have 3.12 compatible wheels available on PyPI.Tests added / passed
📚 Documentation preview 📚: https://datacube-core--1587.org.readthedocs.build/en/1587/