[pull] main from kubeflow:main

.github/workflows/build.yml

@@ -22,7 +22,7 @@ jobs:
       - name: Setup Go
         uses: actions/setup-go@v5
         with:
-          go-version: "1.21"
+          go-version: "1.22"
       - name: Set up Python
         uses: actions/setup-python@v5
         with:

.github/workflows/ui-bff-build.yml

@@ -18,7 +18,7 @@ jobs:
       - name: Setup Go
         uses: actions/setup-go@v5
         with:
-          go-version: "1.22.2"
+          go-version: "1.23.5"
 
       - name: Clean
         working-directory: clients/ui/bff
@@ -27,7 +27,7 @@ jobs:
       - name: Lint
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.57.2
+          version: v1.63.4
           working-directory: clients/ui/bff/
 
       - name: Build

README.md

@@ -42,7 +42,7 @@ Model registry provides a central repository for model developers to store and m
 8. [UI](.clients/ui/README.md)
 
 ## Pre-requisites:
-- go >= 1.21
+- go >= 1.22
 - protoc v24.3 - [Protocol Buffers v24.3 Release](https://github.com/protocolbuffers/protobuf/releases/tag/v24.3)
 - npm >= 10.2.0 - [Installing Node.js and npm](https://docs.npmjs.com/downloading-and-installing-node-js-and-npm)
 - Java >= 11.0
@@ -173,7 +173,7 @@ To delete something, simply update its status.
 ## Tips
 ### Pull image rate limiting
 
-Ocassionally you may encounter an 'ImagePullBackOff' error when deploying the Model Registry manifests. See example below for the `model-registry-db` container. 
+Ocassionally you may encounter an 'ImagePullBackOff' error when deploying the Model Registry manifests. See example below for the `model-registry-db` container.
 
 ```
 Failed to pull image “mysql:8.3.0”: rpc error: code = Unknown desc = fetching target platform image selected from image index: reading manifest sha256:f9097d95a4ba5451fff79f4110ea6d750ac17ca08840f1190a73320b84ca4c62 in docker.io/library/mysql: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

clients/python/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "model-registry"
-version = "0.2.12"
+version = "0.2.13"
 description = "Client for Kubeflow Model Registry"
 authors = ["Isabella Basso do Amaral <[email protected]>"]
 license = "Apache-2.0"

clients/python/src/model_registry/__init__.py

@@ -1,6 +1,6 @@
 """Main package for the Kubeflow model registry."""
 
-__version__ = "0.2.12"
+__version__ = "0.2.13"
 
 from ._client import ModelRegistry
 

clients/python/src/model_registry/core.py

@@ -78,7 +78,7 @@ def insecure_connection(
             user_token: The PEM-encoded user token as a string.
         """
         return cls(
-            Configuration(host=f"{server_address}:{port}", access_token=user_token)
+            Configuration(host=f"{server_address}:{port}", access_token=user_token, verify_ssl=False)
         )
 
     @asynccontextmanager

clients/python/src/mr_openapi/configuration.py

@@ -53,8 +53,11 @@ class Configuration:
       string values to replace variables in templated server configuration.
       The validation of enums is performed for variables with defined enum
       values before.
-    :param ssl_ca_cert: str - the path to a file of concatenated CA certificates
+    :param ssl_ca_cert: str - The path to a file of concatenated CA certificates
       in PEM format.
+    :param verify_ssl: bool - Whether to verify the SSL certificate when making API 
+      requests to an HTTPS server.
+      Set to False to disable verification, default=True.
 
     :Example:
     """
@@ -74,6 +77,7 @@ def __init__(
         server_operation_index=None,
         server_operation_variables=None,
         ssl_ca_cert=None,
+        verify_ssl=True,
     ) -> None:
         """Constructor."""
         self._base_path = "https://localhost:8080" if host is None else host
@@ -133,7 +137,7 @@ def __init__(
         """Debug switch
         """
 
-        self.verify_ssl = True
+        self.verify_ssl = verify_ssl
         """SSL/TLS verification
            Set this to false to skip verifying SSL certificate when calling API
            from https server.

clients/python/tests/regression_test.py

@@ -1,4 +1,5 @@
 import pytest
+import requests
 
 from model_registry import ModelRegistry
 from model_registry.types.artifacts import ModelArtifact
@@ -99,3 +100,35 @@ async def test_create_standalone_model_artifact(client: ModelRegistry):
     assert mv.id
     mv_ma = await client._api.upsert_model_version_artifact(new_ma, mv.id)
     assert mv_ma.id == new_ma.id
+
+@pytest.mark.e2e
+async def test_patch_model_artifacts_artifact_type(client: ModelRegistry):
+    """Patching Artifacts makes the model registry server panic.
+
+    reported with https://issues.redhat.com/browse/RHOAIENG-16932
+    """
+    name = "test_model"
+    version = "1.0.0"
+    rm = client.register_model(
+        name,
+        "s3",
+        model_format_name="test_format",
+        model_format_version="test_version",
+        version=version,
+    )
+    assert rm.id
+    mv = client.get_model_version(name, version)
+    assert mv
+    assert mv.id
+    ma = client.get_model_artifact(name, version)
+    assert ma
+    assert ma.id
+
+    payload = { "modelFormatName": "foo", "artifactType": "model-artifact" }
+    from .conftest import REGISTRY_HOST, REGISTRY_PORT
+    response = requests.patch(url=f"{REGISTRY_HOST}:{REGISTRY_PORT}/api/model_registry/v1alpha3/artifacts/{ma.id}", json=payload, timeout=10, headers={"Content-Type": "application/json"})
+    assert response.status_code == 200
+    ma = client.get_model_artifact(name, version)
+    assert ma
+    assert ma.id
+    assert ma.model_format_name == "foo"

clients/ui/Dockerfile

@@ -4,13 +4,15 @@ ARG BFF_SOURCE_CODE=./bff
 
 # Set the base images for the build stages
 ARG NODE_BASE_IMAGE=node:20
-ARG GOLANG_BASE_IMAGE=golang:1.22.2
+ARG GOLANG_BASE_IMAGE=golang:1.23.5
 ARG DISTROLESS_BASE_IMAGE=gcr.io/distroless/static:nonroot
 
 # UI build stage
 FROM ${NODE_BASE_IMAGE} AS ui-builder
 
 ARG UI_SOURCE_CODE
+ARG DEPLOYMENT_MODE
+ARG MOCK_AUTH
 
 WORKDIR /usr/src/app
 

clients/ui/Makefile

@@ -50,15 +50,15 @@ docker-build:
 
 .PHONY: docker-build-standalone
 docker-build-standalone:
-	MOCK_AUTH=true DEPLOYMENT_MODE=standalone $(CONTAINER_TOOL) build -t ${IMG_UI_STANDALONE} .
+	$(CONTAINER_TOOL) build --build-arg MOCK_AUTH=true --build-arg DEPLOYMENT_MODE=standalone -t ${IMG_UI_STANDALONE} .
 
 .PHONY: docker-buildx
 docker-buildx:
 	docker buildx build --platform ${PLATFORM} -t ${IMG_UI} --push .
 
 .PHONY: docker-buildx-standalone
 docker-buildx-standalone:
-	MOCK_AUTH=true DEPLOYMENT_MODE=standalone docker buildx build --platform ${PLATFORM} -t ${IMG_UI_STANDALONE} --push .
+	docker buildx build --build-arg MOCK_AUTH=true --build-arg DEPLOYMENT_MODE=standalone --platform ${PLATFORM} -t ${IMG_UI_STANDALONE} --push .
 
 ############ Push ############
 
@@ -83,7 +83,7 @@ frontend-build:
 
 .PHONY: frontend-build-standalone
 frontend-build-standalone:
-	MOCK_AUTH=true DEPLOYMENT_MODE=standalone cd frontend && npm run build:prod
+	cd frontend && MOCK_AUTH=true DEPLOYMENT_MODE=standalone npm run build:prod
 
 .PHONY: bff-build
 bff-build:

clients/ui/bff/Makefile

@@ -64,7 +64,7 @@ ENVTEST ?= $(LOCALBIN)/setup-envtest-$(ENVTEST_VERSION)
 GOLANGCI_LINT ?= $(LOCALBIN)/golangci-lint-$(GOLANGCI_LINT_VERSION)
 
 ## Tool Versions
-GOLANGCI_LINT_VERSION ?= v1.57.2
+GOLANGCI_LINT_VERSION ?= v1.63.4
 ENVTEST_VERSION ?= release-0.17
 
 .PHONY: envtest